Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated koa router #90

Closed
GalacticHypernova opened this issue Oct 19, 2023 · 10 comments
Closed

Outdated koa router #90

GalacticHypernova opened this issue Oct 19, 2023 · 10 comments

Comments

@GalacticHypernova
Copy link

warning @nuxtjs/tailwindcss > tailwind-config-viewer > @koa/router@9.4.0: IMPORTANT 10x+ PERFORMANCE UPGRADE: Please upgrade to v12.0.1+ as we have fixed an issue with debuglog causing 10x slower router benchmark performance, see koajs/router#173
@metkm
Copy link

metkm commented Oct 20, 2023

Having the same issue. I guess this was the reason why my dev server become so slow?

@GalacticHypernova
Copy link
Author

Most likely..

@maximepvrt
Copy link

@rogden 🙏

@NBZ-Vasil
Copy link

Same thing here, experienced a sharp performance drop on my dev machine after installing @nuxtjs/tailwindcss.

@metkm
Copy link

metkm commented Oct 30, 2023

This is related to nuxt/ui#845

@rogden
Copy link
Owner

rogden commented Oct 30, 2023

Thanks for the report. Will look at this tonight and update the dep. What was the variable that caused the perf issue? Given the Koa router version in this project has been the same since the beginning...why the slowness now?

@GalacticHypernova
Copy link
Author

GalacticHypernova commented Oct 30, 2023 •
edited
Loading

@rogden the slowness was always there. The warning was only added recently, as seen here. As far as I understood, the cause was a conversion of debug to debuglog.

@rogden rogden pinned this issue Oct 30, 2023
@rogden
Copy link
Owner

rogden commented Oct 31, 2023 •
edited
Loading

Updated in v1.7.3

@rogden rogden closed this as completed Oct 31, 2023
@GalacticHypernova
Copy link
Author

Thank you very much!

@NBZ-Vasil
Copy link

Thanks for the quick resolution

@rogden rogden unpinned this issue Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rogden @maximepvrt @metkm @GalacticHypernova @NBZ-Vasil