Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click to select item in initial sync diff viewer #707

Closed
JohnnyMorganz opened this issue Jul 4, 2023 · 4 comments · Fixed by #709
Closed

Click to select item in initial sync diff viewer #707

JohnnyMorganz opened this issue Jul 4, 2023 · 4 comments · Fixed by #709
Labels
impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. scope: plugin Relevant to the Roblox Studio plugin type: enhancement Feature or improvement that should potentially happen

Comments

@JohnnyMorganz
Copy link
Contributor

It would be nice if the instances in the diff viewer were clickable which would focus the selection onto that item.

For example, in the sync view below, I would like to click on "Part" to find out which part exactly it was added to
image

@boatbomber
Copy link
Member

What would you expect to happen if you click on a new addition that has no Instance yet?

@boatbomber
Copy link
Member

Additionally, clicking is currently used to open the dropdown of changes. We can use right clicking for selection, perhaps.

@boatbomber boatbomber added type: enhancement Feature or improvement that should potentially happen scope: plugin Relevant to the Roblox Studio plugin impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. labels Jul 4, 2023
@boatbomber
Copy link
Member

boatbomber commented Jul 4, 2023

After trying a few methods, the one I found to be the easiest to use:

Right clicking selects the Instance (if the Instance exists). Left clicking an Instance will still open the changes table, but Instances with no changes table can also be selected by a left click for convenience.

@boatbomber boatbomber added the status: in-progress Someone is working on this last time we checked. label Jul 4, 2023
@boatbomber
Copy link
Member

After review, the interaction model has been redesigned as follows:

Double clicking selects the Instance, if the Instance exists. Single clicking opens the changes list, if changes exist.

Tooltips indicate which actions are available for the underlying DOM element.

@kennethloeffler kennethloeffler removed the status: in-progress Someone is working on this last time we checked. label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: small Minor papercuts in Rojo that don't warrant immediate resolutoin. scope: plugin Relevant to the Roblox Studio plugin type: enhancement Feature or improvement that should potentially happen
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants