Skip to content

Commit

Permalink
Take third parameter for Sidekiq error_handler (#1136)
Browse files Browse the repository at this point in the history
In
sidekiq/sidekiq@2870516
Sidekiq starts accepting a the Sidekiq Configuration option as a
parameter to error_handlers and marks two parameter handlers as
deprecated.  This change adds a third parameter to the handler to accept
that configuration and defaults the value to `nil` since

1. Older versions of Sidekiq will not pass a third parameter
2. Rollbar does not need to do anything with that value (yet?)
  • Loading branch information
atomaka authored Nov 27, 2023
1 parent 07e0432 commit 8c6a9e9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/rollbar/plugins/sidekiq.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
chain.add Rollbar::Sidekiq::ResetScope
end

config.error_handlers << proc do |e, context|
config.error_handlers << proc do |e, context, _sidekiq_config = nil|
Rollbar::Sidekiq.handle_exception(context, e)
end
end
Expand Down

0 comments on commit 8c6a9e9

Please sign in to comment.