Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning in Rack 3 #1134

Closed
morgoth opened this issue Nov 7, 2023 · 4 comments · Fixed by #1142
Closed

Deprecation warning in Rack 3 #1134

morgoth opened this issue Nov 7, 2023 · 4 comments · Fixed by #1142

Comments

@morgoth
Copy link
Contributor

morgoth commented Nov 7, 2023

On 404 responses, I'm getting deprecation warning in logs:

ActionController::RoutingError (No route matches [GET] "/login.html"):
  
/usr/local/bundle/ruby/3.2.0/gems/rollbar-3.4.1/lib/rollbar/middleware/rails/show_exceptions.rb:10: warning: Request#[] is deprecated and will be removed in a future version of Rack. Please use request.params[] instead

Rails 7.1.1
rack 3.0.8

@jonmchan
Copy link

I confirm this issue on Rails 7.1.2. Same error.

rails (7.1.2)
rack (3.0.8)

@ghost
Copy link

ghost commented Nov 16, 2023

Hey @morgoth @jonmchan, Thanks for reporting this issue. I opened an internal bug ticket for this issue (131090). I'll get back to you after we schedule it.

@ghost
Copy link

ghost commented Nov 16, 2023

Hey @morgoth @jonmchan, We scheduled work on the Ruby SDK after Thanksgiving. Our Ruby dev is currently headed down on another crucial initiative. I was informed that another fix will probably require a breaking change; hence expect a major version bump.

@jonmchan
Copy link

Thanks for the update and thanks for addressing this! Will be on the look out for the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants