Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perhaps rollbar should be at 1.x.x? #119

Closed
jcwilk opened this issue Jun 27, 2014 · 5 comments
Closed

Perhaps rollbar should be at 1.x.x? #119

jcwilk opened this issue Jun 27, 2014 · 5 comments

Comments

@jcwilk
Copy link

jcwilk commented Jun 27, 2014

We love Rollbar and use it for everything, but all of our branches suddenly started failing on CI last night because a breaking change (Rollbar.report_exception returning "disabled" instead of a hash in test... Granted, it's just in test, but it was a significant disruption to our development flow across the team) was released with only a minor bump due to rollbar being on 0.x.x.

Not sure if you guys are trying to follow Semantic Versioning, but according to http://semver.org/ :

Major version zero (0.y.z) is for initial development.
Anything may change at any time.
The public API should not be considered stable.

"How do I know when to release 1.0.0?

If your software is being used in production, it should probably already be 1.0.0. If you have a stable API on which users have come to depend, you should be 1.0.0. If you're worrying a lot about backwards compatibility, you should probably already be 1.0.0."

Given that you have 46 forks of the project and many paying customers using your gem in production, it seems like it's due to be >= 1.0.0. If it was, we'd be able to more accurately lock the gem by a specific version range, and when you wanted to release breaking changes you'd be able to bump the major.

Thoughts?

@brianr
Copy link
Member

brianr commented Jun 27, 2014

Hey @jcwilk - thanks for asking about this. We've been holding off on 1.0 because we have some significant API changes that we're planning, and 1.0 seems like a good time to release them. But it might be best to go 1.0 now and save that for 2.0...

We have been treating minor version changes (0.12.20 -> 0.13.0) as "breaking". If you pin yourself to a minor version then you should be safe, e.g.

gem 'rollbar', '~> 0.13.0'

I also think you bring up a good case for 1.0; we'll discuss that internally.

@jcwilk
Copy link
Author

jcwilk commented Jun 27, 2014

Thanks so much for the quick reply! I'll follow your advice and adjust our pinned versions accordingly for now.

@brianr
Copy link
Member

brianr commented Jul 25, 2014

We decided we buy your argument about 1.0. Thanks for bringing it up! 1.0.0 was released on 7/16/14 in 487acba .

@brianr brianr closed this as completed Jul 25, 2014
@jcwilk
Copy link
Author

jcwilk commented Jul 25, 2014

Happy to help :D Thanks

@dgilperez
Copy link

🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants