Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing aws-sdk-sqs when running tests and failing tests #659

Closed
ArturMoczulski opened this issue Dec 13, 2017 · 1 comment
Closed

Missing aws-sdk-sqs when running tests and failing tests #659

ArturMoczulski opened this issue Dec 13, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@ArturMoczulski
Copy link
Contributor

ArturMoczulski commented Dec 13, 2017

Running rake spec results in:

Bundler::GemRequireError:
  There was an error while trying to load the gem 'shoryuken'.
  Gem Load Error is: AWS SDK 3 requires aws-sdk-sqs to be installed separately. Please add gem 'aws-sdk-sqs' to your Gemfile

This is only solved if I add aws-sdk-sqs to the Gemfile so I assume we should add it. If there is a different procedure to run tests then we should update README.md.

Once the problem with running spec is solved, we have three failing tests:

Failed examples:

rspec ./spec/rollbar/item_spec.rb:639 # Rollbar::Item#dump with Redis instance in payload and ActiveSupport is enabled dumps to JSON correctly
rspec ./spec/rollbar/plugins/rails_js_spec.rb:11 # ApplicationController renders the snippet and config in the response
rspec ./spec/rollbar_spec.rb:1323 # Rollbar project_gems should handle regex gem patterns
@ArturMoczulski ArturMoczulski self-assigned this Dec 13, 2017
@ArturMoczulski ArturMoczulski changed the title Issues running the test suite and failing tests Missing aws-sdk-sqs when running tests and failing tests Dec 13, 2017
@rivkahstandig3636 rivkahstandig3636 added this to the v2.15.6 milestone Dec 27, 2017
@ArturMoczulski
Copy link
Contributor Author

The PR for this has been already merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants