Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #487: Automatically add Rollbar::ActiveJob to ActionMailer::DeliveryJob #819

Merged
merged 5 commits into from
Feb 19, 2019
Merged

Issue #487: Automatically add Rollbar::ActiveJob to ActionMailer::DeliveryJob #819

merged 5 commits into from
Feb 19, 2019

Conversation

waltjones
Copy link
Contributor

@waltjones waltjones commented Feb 12, 2019 •
edited
Loading

Fixes #487

From the issue report:

Rails has a built-in job called ActionMailer::DeliveryJob which is used when you call deliver_later on your action mailer emails. Currently errors in that job are not being reported.

This PR automatically hooks into that job as part of Rails integration.

ArturMoczulski
ArturMoczulski suggested changes Feb 17, 2019
View reviewed changes
Copy link
Contributor

@ArturMoczulski ArturMoczulski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some conflict with the latest active_job support I merged intomaster. EDIT: resolved.

@waltjones waltjones merged commit a3c24c9 into master Feb 19, 2019
@waltjones waltjones deleted the wj-action-mailer-delivery-job branch June 27, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturMoczulski ArturMoczulski ArturMoczulski requested changes

@rokob rokob Awaiting requested review from rokob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waltjones @ArturMoczulski