Prevent recursive failsafes

[johnsyweb]

Context

See #632

Change

• d6d3f5b : necessary to get rspec to run
• 3e42f31 : me familiarising myself with the #process_item method
• 297aac4 : is the work to address Gem failsafe error generating 100ks of events when no network connection #632
• 9cf0ad2 : is some refactoring I needed to do to be happy to push this upstream
• 9779b37 : removes a whole lot of deprecation warnings making the spec output legible This breaks older systems

Confirmation

E, [2019-10-31T04:39:43.508233 #1135] ERROR -- : [Rollbar] Sending failsafe response due to SocketError: "Failed to open TCP connection to api.rollbar.com:443 (getaddrinfo: Temporary failure in name resolution)" in /usr/lib/ruby/2.5.0/net/http.rb:939:in `rescue in block in connect': error in process_item
I, [2019-10-31T04:39:43.508357 #1135]  INFO -- : [Rollbar] Scheduling item
E, [2019-10-31T04:39:43.508698 #1135] ERROR -- : [Rollbar] Item: #<Rollbar::Item:0x0000000004c314b0>
I, [2019-10-31T04:39:43.508853 #1135]  INFO -- : [Rollbar] Sending item
E, [2019-10-31T04:39:43.509462 #1135] ERROR -- : [Rollbar] Error processing the item: SocketError, Failed to open TCP connection to api.rollbar.com:443 (getaddrinfo: Temporary failure in name resolution). Item: {"access_token"=>"*******", "data"=>{:level=>"error", :environment=>"staging", :body=>{:message=>{:body=>"Failsafe from rollbar-gem. SocketError: \"Failed to open TCP connection to api.rollbar.com:443 (getaddrinfo: Temporary failure in name resolution)\" in /usr/lib/ruby/2.5.0/net/http.rb:939:in `rescue in block in connect': error in process_item"}}, :notifier=>{:name=>"rollbar-gem", :version=>"2.22.1"}, :custom=>{:orig_uuid=>nil, :orig_host=>nil}, :internal=>true, :failsafe=>true}}
E, [2019-10-31T04:39:43.509560 #1135] ERROR -- : [Rollbar] Item has already failed. Not re-raising

[waltjones]

@johnsyweb Looks good, thank you!

[johnsyweb]

Thanks for the quick turnaround, @waltjones, much appreciated . When do you expect to release the next version of the gem, please?

[waltjones]

One to two weeks. There are a handful of other things that need to go in. One less now though. ;)

[johnsyweb]

Perfect. Thank you very much.