Handle error encoding string without failing the occurrence #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4
reviewed
Apr 27, 2020
| @@ -30,6 +30,9 @@ def encode | |||
| end | |||
|
|
|||
| object.is_a?(Symbol) ? encoded_value.to_sym : encoded_value | |||
| rescue StandardError => e | |||
| # If encoding fails for any reason, replace the string with a diagnostic error. | |||
| "error encoding string: #{e.class}: #{e.message}" | |||
There was a problem hiding this comment.
I have a really robust solution in the EncodedString gem which I extracted from some work in rspec ¯\_(ツ)_/¯
use it as a reference or rely on it. Either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific strings in an occurrence may contain encodings that cannot map to UTF-8. For example, the Vietnamese encoding Windows-1258 allows sequences that have no valid mapping in UTF-8.
When a mapping fails, it is better to provide a diagnostic error for the specific string than to fail the occurrence. Failsafe error occurrences don't show where the failed string mapping happened, and don't provide useful information about the original error. Preserving and sending the original error is an improvement on both points.