Fix Rollbar JS middleware truncating response body #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JS middleware injects Rollbar JS snippet into the response body if not already added. If for some reason the `Content-Length` header was previously set by another middleware, we also need to update that header to reflect the new response body size.
wpolicarpo
force-pushed
the
fix-js-middleware-truncating-response-body
branch
from
6b706cc
to
31f58c0
Compare
|
@wpolicarpo Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JS middleware injects Rollbar JS snippet into the response body if not already added.
If for some reason the
Content-Lengthheader was previously set by another middleware, we also need to update that header to reflect the new response body size.Fixes #960.