Improved LambdaHandler event typing #711
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@types/aws-lambda
allows the event to be typed as shown here: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/aws-lambda/index.d.ts#L1028Wrapping the handler with
lambdaHandler()
removed the@types/aws-lambda
typing. Forcing theevent
to always be of typeobject
breaks the expected type ofevent
in the handler. This change would enable you to typelambdaHandler()
similarly toHandler
from@types/aws-lambda
. It would reinstate the desired type ofevent
for the handler.It should also be considered to enable typing of the result and to use the
Context
type from@types/aws-lambda
instead ofobject
.