Enable RollbarProxy for sending Rollbar events #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturMoczulski
approved these changes
Apr 13, 2019
| @@ -71,7 +71,23 @@ function _makeZoneRequest(accessToken, url, method, data, callback, requestFacto | |||
| } | |||
| } | |||
|
|
|||
| /* global RollbarProxy */ | |||
| function _proxyRequest(json, callback) { | |||
| var rollbarProxy = new RollbarProxy(); | |||
There was a problem hiding this comment.
I understand that the idea behind RollbarProxy is to come from other JS sources, just like in the Cordova SDK. Is that correct?
There was a problem hiding this comment.
Right. RollbarProxy is defined externally.
|
LGTM :) |
waltjones
changed the title
1 task
mudetroit
pushed a commit
that referenced
this pull request
Mar 14, 2024
Enable RollbarProxy for sending Rollbar events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cordova support is driving the need for this, but it can be used by anyone who makes a
RollbarProxyobject available.