Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG REPORT] - Multiple bugs (IGRF Export, Ruleset for AdHoc games) #525

Closed
bullseye555 opened this issue Aug 4, 2022 · 2 comments · Fixed by #526
Closed

[BUG REPORT] - Multiple bugs (IGRF Export, Ruleset for AdHoc games) #525

bullseye555 opened this issue Aug 4, 2022 · 2 comments · Fixed by #526

Comments

@bullseye555
Copy link
Contributor

Bug 1 (This is one I found): When downloading StatsBook after setting the Teams for each of PBT, PLT etc, the Official name isn't populated into the Penalty Box sheet
image
Expecting Intensive Claire Unit and Bash A Lot to be populated in the statsbook
image

Bug 2 (Reported via the FB group and I've been able to replicate): Starting a game with a ruleset other than WFTDA doesn't honour the changes in the selected ruleset
This applies to both pre-built rulesets (eg: RDCL, RDCL half game, Sevens)
Select Teams and Ruleset, no start time. Select Start Game
image
Go to current game
image
Sevens ruleset should have a 21min half
image
Rules page shows WFTDA as the ruleset applied (when using a custom ruleset, this shows Custom instead of the name of the actual ruleset selected, and doesn't inherit any of the selected ruleset changes)
image
-- Custom ruleset created was JRDA; none of the changes made (such as custom Penalty Definition File) were inherited into the Custom ruleset that was created
image

Manually updating the ruleset correctly honours the ruleset
image
image

There doesn't appear to be any issues in starting a Prepared Game with a different ruleset - both an uploaded IGRF with the ruleset changed, and a game entered directly both had the changed ruleset honoured on game-start

@frank-weinberg
Copy link
Contributor

I'm not sure what you mean with

(when using a custom ruleset, this shows Custom instead of the name of the actual ruleset selected, and doesn't inherit any of the selected ruleset changes)

Aside from that I found the source of Bug 2 and a fix will be in the next release.

"Bug" 1 is not a bug but a feature request in my book - I never considered adding names to the Box Sheets as they are not typed into the statsbook. But I guess it may be useful for preparing paperwork if the team assignment is already known at that time. So this will also be in the next release.

Release ETA: Once I have gotten around to investigating and fixing the bugs reported via another channel. I hope that's some time next week but can't make any promises.

@bullseye555
Copy link
Contributor Author

Thanks Frank

`I'm not sure what you mean with

`(when using a custom ruleset, this shows Custom instead of the name of the actual ruleset selected, and doesn't inherit any of the selected ruleset changes)``
When a custom ruleset (eg, one that is created and not a ruleset included with CRG -- in my example, I've used JRDA) is selected as part of the AdHoc game creation, when the game is started and you navigate to the Rules tab, it shows the word Custom instead of JRDA, and doesn't show any of the changes to the original parent rulset made when creating the JRDA ruleset.

Re: Bug/Feature 1
Understood - every tournament I've ever done statsbook entry for the PBT paperwork has always been input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants