Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable go-da to utilize multi accounts support from celestia-node #93

Closed
Tracked by #92
tzdybal opened this issue Sep 3, 2024 · 1 comment · Fixed by #95
Closed
Tracked by #92

Enable go-da to utilize multi accounts support from celestia-node #93

tzdybal opened this issue Sep 3, 2024 · 1 comment · Fixed by #95
Assignees

Comments

@tzdybal
Copy link
Member

tzdybal commented Sep 3, 2024

Imagine following use case:

  • there is a shared celestia-node instance, providing DA for multiple rollups (operated by single org or even RasS provider, so they can setup keyring properly)
  • each rollup need to use different key

Currently there is no way in go-da to specify key name. Possible solutions are:

  • add key name as an option to Submit method (see: feat: add keyName #89)
  • add generic ([]byte) param to Submit to enable passing any options
  • add new method SubmiWithOptions with generic ([]byte) options
  • add SetKeyName method to go-da interface
  • add generic SetConfig([]byte) method to go-da interface
  • leave go-da interface as is and extend proxy.GetClient to enable passing more options
    • actually the token is already similar use case (but seems way more generic than key name)

This is somehow similar to MaxBlobSize but the other way around. go-da interface is focused strictly on DA operation and not on life-cycle / metadata / configuration.

@tzdybal tzdybal mentioned this issue Sep 3, 2024
11 tasks
@tzdybal tzdybal changed the title enable go-da to utilize multi accounts support from celestia-node Enable go-da to utilize multi accounts support from celestia-node Sep 3, 2024
@tuxcanfly
Copy link
Contributor

Another possible solution is to add a new method e.g. SubmitWithOptions(... Options []byte) which just forwards the options as a opaque bytestring to be decoded by the server.

@tzdybal tzdybal self-assigned this Sep 5, 2024
@tzdybal tzdybal moved this to In Progress in Rollkit Sep 5, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Rollkit Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants