-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GetIDs method #11
Conversation
@MSevey, I have some questions:
|
Error in the workflow file https://github.com/rollkit/go-da/actions/runs/6379741787 |
It looks like you manually requested the review? If so, then it doesn't automatically assign someone. It looks like the auto review request hit some ignore case: https://github.com/rollkit/go-da/actions/runs/6379741784/job/17313941628?pr=11#step:2:8 Did you initially open the PR as a draft? There might be an edge case with ignoring drafts but only running the workflow on open PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small nit.
581e1d2
to
cb3e5d6
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Overview
GetIDs
method return all IDs available at given height. This method combined withGet
provides functionality ofGetAll
, but at the same time is more flexible. Getting contents of all blobs might be the heavy and unnecessary.Resolves #10
Checklist