Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about were to write panel pages #161

Open
ng-druid opened this issue Jul 8, 2024 · 0 comments
Open

Think about were to write panel pages #161

ng-druid opened this issue Jul 8, 2024 · 0 comments
Labels
canva issues related to canva integration

Comments

@ng-druid
Copy link
Contributor

ng-druid commented Jul 8, 2024

rollthecloudinc/spearhead-canva-objects - private repo w/ pages site mapped to /public

  • public (map Github pages site to this folder)
    • panelpage
    • media
    • schema
    • .nojekll
  • design
    • [design id]
      • [submission id]
      • [submission id]

The contract system currently only supports a single depth. It takes the first path part after shapeshifter and looks for a contract named the same in the contracts directory at the root of the repo. That isn't going to work here unless we name the contracts using the team_design.

repo root ie. spearhead-canva-objects

  • contracts
    • teamId-designId.json
  • teamId-designId
    • fb911257-5f6c-4d19-942e-de9740435ecd.json
    • 3c5a9a55-5eed-42db-81f3-1b9b1fa9334d.json
    • 87b63da8-6065-4acc-b666-aefe8e3456c8.json
  • media
    • 76c5813f-8712-4e12-ac4f-a4ea3988edeb.jpeg
    • 05696c0c-189f-4ba4-b231-381cd163dd03.png
  • panelpage
    • teamId-designId.json
    • teamId-designId.json
    • teamId-designId.json

although panel page ids are currently generated a guid at random. Is it worth it to implement a solution to change the name?

Submit to /teamId-designId - given one form per design - right

The team-design must exist before submissions accepted.

What about media. Media currently only writes to media/*. We just need to rename with guid. Although we would really like to support paths like with entities.

How are contract schemas created from merely a panel page form. The structure can be immitated as converting entries to json. However, we also need to support things like validation and conditions (rules).


We can also go in a different direction and implement paths for contracts.

{
	"id": "person.schema",
	"path": "/ads/*/*",
	"schema": {
		"$id": "https://example.com/person.schema.json",
		"$schema": "https://json-schema.org/draft/2020-12/schema",
		"properties": {
			"age": {
				"description": "Age in years which must be equal to or greater than zero.",
				"minimum": 0,
				"type": "integer"
			},
			"firstName": {
				"description": "The person's first name.",
				"type": "string"
			},
			"lastName": {
				"description": "The person's last name.",
				"type": "string"
			}
		},
		"title": "Person",
		"type": "object"
	},
	"userId": "b7a9bac5-5fef-4aa6-bf12-d536c156e453"
}

what about pages support in a design?

@ng-druid ng-druid added the canva issues related to canva integration label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canva issues related to canva integration
Projects
None yet
Development

No branches or pull requests

1 participant