fix(alias): properly initialize custom resolvers #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkit
reviewed
May 29, 2020
packages/alias/src/index.ts
Outdated
| typeof customResolver.buildStart === 'function' && | ||
| customResolver.buildStart.call(this, inputOptions) | ||
| ) | ||
| ).then(() => {}); |
There was a problem hiding this comment.
What do you expect to catch? If something fails, then Rollup's buildStart will pick it up. The empty then is just to satisfy the expected empty return type of buildStart.
There was a problem hiding this comment.
We could also do a type cast here of course, but I do not think this is performance critical.
There was a problem hiding this comment.
just to satisfy the expected empty return type
Ah! Sorry
shellscape
approved these changes
Jun 1, 2020
LarsDenBakker
pushed a commit
to LarsDenBakker/plugins
that referenced
this pull request
Sep 12, 2020
* fix(alias): properly initialize custom resolvers * chore(commonjs): add helpful comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
aliasThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Resolves #203
Description
This will make sure that for all custom resolvers
buildStarthooks are run if present duringbuildStartresolveIdhook is run with correctthiscontext