Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL ignores "shareable" in URL but always loads default example #118

Closed
lukastaegert opened this issue Jan 26, 2018 · 1 comment · Fixed by sveltejs/sapper#107 or #121
Closed

Comments

@lukastaegert
Copy link
Member

lukastaegert commented Jan 26, 2018

Not sure when this was introduced but no matter what URL is used to open the REPL, it is always replaced with the default example. This severely limits its usefulness for communicating code samples.

@lukastaegert lukastaegert changed the title REPL no loader keeps address bar in sync with code REPL does not keep address bar in sync with code Jan 26, 2018
@lukastaegert lukastaegert changed the title REPL does not keep address bar in sync with code REPL ignores "shareable" in URL but always loads default example Jan 26, 2018
@lukastaegert
Copy link
Member Author

Current findings:
The preload function in routes/repl/index.html always receives an empty query object on the client no matter what is entered into the address bar. On the server when doing SSR, the address seems to be read properly but this is apparently ignored/overwritten by the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant