Add support for IPv6 hosts

romaindso · Jul 10, 2017 · 4bfc45a · 4bfc45a
1 parent 89250e5
commit 4bfc45a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/packages/react-dev-utils/prepareProxy.js b/packages/react-dev-utils/prepareProxy.js
@@ -73,7 +73,9 @@ module.exports = function prepareProxy(proxy) {
   // `proxy` lets you specify alternate servers for specific requests.
   // It can either be a string or an object conforming to the Webpack dev server proxy configuration
   // https://webpack.github.io/docs/webpack-dev-server.html
-  if (!proxy) return undefined;
+  if (!proxy) {
+    return undefined;
+  }
   if (typeof proxy !== 'object' && typeof proxy !== 'string') {
     console.log(
       chalk.red(

diff --git a/packages/react-scripts/scripts/start.js b/packages/react-scripts/scripts/start.js
@@ -36,6 +36,7 @@ const config = require('../config/webpack.config.dev');
 const devServerConfig = require('../config/webpackDevServer.config');
 const createWebpackCompiler = require('./utils/createWebpackCompiler');
 const prepareProxy = require('react-dev-utils/prepareProxy');
+const url = require('url');
 
 const useYarn = fs.existsSync(paths.yarnLockFile);
 const cli = useYarn ? 'yarn' : 'npm';
@@ -52,6 +53,12 @@ const HOST = process.env.HOST || '0.0.0.0';
 
 function run(port) {
   const protocol = process.env.HTTPS === 'true' ? 'https' : 'http';
+  const formattedUrl = url.format({
+    protocol,
+    hostname: HOST,
+    port,
+    pathname: '/',
+  });
 
   // Create a webpack compiler that is configured with custom messages.
   const compiler = createWebpackCompiler(
@@ -63,7 +70,7 @@ function run(port) {
       console.log();
       console.log('The app is running at:');
       console.log();
-      console.log(`  ${chalk.cyan(`${protocol}://${HOST}:${port}/`)}`);
+      console.log(`  ${chalk.cyan(formattedUrl)}`);
       console.log();
       console.log('Note that the development build is not optimized.');
       console.log(
@@ -93,7 +100,7 @@ function run(port) {
     console.log(chalk.cyan('Starting the development server...'));
     console.log();
 
-    openBrowser(`${protocol}://${HOST}:${port}/`);
+    openBrowser(formattedUrl);
   });
 }