From 4b62c7bb1c9caa3ba076b09480f3a39bf98a878a Mon Sep 17 00:00:00 2001 From: Arend van Beelen jr Date: Fri, 21 Jul 2023 15:00:47 +0200 Subject: [PATCH] PR feedback --- .../src/analyzers/nursery/use_import_restrictions.rs | 2 +- .../useImportRestrictions/validPackagePrivateImports.js | 9 ++++++--- .../validPackagePrivateImports.js.snap | 9 ++++++--- 3 files changed, 13 insertions(+), 7 deletions(-) diff --git a/crates/rome_js_analyze/src/analyzers/nursery/use_import_restrictions.rs b/crates/rome_js_analyze/src/analyzers/nursery/use_import_restrictions.rs index dea62e25452..3c7d69d0475 100644 --- a/crates/rome_js_analyze/src/analyzers/nursery/use_import_restrictions.rs +++ b/crates/rome_js_analyze/src/analyzers/nursery/use_import_restrictions.rs @@ -119,7 +119,7 @@ fn get_restricted_import(module_path: &SyntaxTokenText) -> Option = module_path.text().split('/').collect(); + let mut path_parts: Vec<_> = module_path.text().split('/').collect(); let mut index_filename = None; if let Some(extension) = get_extension(&path_parts) { diff --git a/crates/rome_js_analyze/tests/specs/nursery/useImportRestrictions/validPackagePrivateImports.js b/crates/rome_js_analyze/tests/specs/nursery/useImportRestrictions/validPackagePrivateImports.js index 84471b94320..a82fd7f72f0 100644 --- a/crates/rome_js_analyze/tests/specs/nursery/useImportRestrictions/validPackagePrivateImports.js +++ b/crates/rome_js_analyze/tests/specs/nursery/useImportRestrictions/validPackagePrivateImports.js @@ -3,9 +3,6 @@ // Imports within the same module are always allowed. import { fooPackageVariable } from "./foo.js"; -// Imports within the same module are always allowed. -import { fooPackageVariable } from "./foo.js"; - // Resources (anything other than JS/TS files) are exempt. import { barResource } from "../aunt/bar.png"; @@ -17,3 +14,9 @@ import { subPackageVariable } from "./sub/index.js"; // Library imports are exempt. import useAsync from "react-use/lib/useAsync"; + +// Including library imports with an extension. +import map from "lodash/map.js"; + +// Scoped packages work too. +import netlify from "@astrojs/netlify/functions.js"; diff --git a/crates/rome_js_analyze/tests/specs/nursery/useImportRestrictions/validPackagePrivateImports.js.snap b/crates/rome_js_analyze/tests/specs/nursery/useImportRestrictions/validPackagePrivateImports.js.snap index 74bc6b29ae6..f3a159f401f 100644 --- a/crates/rome_js_analyze/tests/specs/nursery/useImportRestrictions/validPackagePrivateImports.js.snap +++ b/crates/rome_js_analyze/tests/specs/nursery/useImportRestrictions/validPackagePrivateImports.js.snap @@ -9,9 +9,6 @@ expression: validPackagePrivateImports.js // Imports within the same module are always allowed. import { fooPackageVariable } from "./foo.js"; -// Imports within the same module are always allowed. -import { fooPackageVariable } from "./foo.js"; - // Resources (anything other than JS/TS files) are exempt. import { barResource } from "../aunt/bar.png"; @@ -24,6 +21,12 @@ import { subPackageVariable } from "./sub/index.js"; // Library imports are exempt. import useAsync from "react-use/lib/useAsync"; +// Including library imports with an extension. +import map from "lodash/map.js"; + +// Scoped packages work too. +import netlify from "@astrojs/netlify/functions.js"; + ```