From 608d9735a2167832a15994d9cc290d561d6cd3a9 Mon Sep 17 00:00:00 2001
From: Denis Bezrukov <6227442+denbezrukov@users.noreply.github.com>
Date: Sat, 12 Nov 2022 17:36:04 +0200
Subject: [PATCH] fix(rome_js_formatter): new expression attribute
---
.../jsx/attribute/expression_attribute_value.rs | 1 -
crates/rome_js_formatter/src/lib.rs | 10 +++++-----
.../tests/specs/jsx/attributes.jsx | 6 ++++++
.../tests/specs/jsx/attributes.jsx.snap | 15 +++++++++++++++
4 files changed, 26 insertions(+), 6 deletions(-)
diff --git a/crates/rome_js_formatter/src/jsx/attribute/expression_attribute_value.rs b/crates/rome_js_formatter/src/jsx/attribute/expression_attribute_value.rs
index 8617905210e..c3a3711846b 100644
--- a/crates/rome_js_formatter/src/jsx/attribute/expression_attribute_value.rs
+++ b/crates/rome_js_formatter/src/jsx/attribute/expression_attribute_value.rs
@@ -89,7 +89,6 @@ pub(crate) fn should_inline_jsx_expression(
| JsObjectExpression(_)
| JsArrowFunctionExpression(_)
| JsCallExpression(_)
- | JsNewExpression(_)
| JsImportCallExpression(_)
| ImportMeta(_)
| JsFunctionExpression(_)
diff --git a/crates/rome_js_formatter/src/lib.rs b/crates/rome_js_formatter/src/lib.rs
index 135fd8dfaed..9d804f7f847 100644
--- a/crates/rome_js_formatter/src/lib.rs
+++ b/crates/rome_js_formatter/src/lib.rs
@@ -787,11 +787,11 @@ function() {
// use this test check if your snippet prints as you wish, without using a snapshot
fn quick_test() {
let src = r#"
-const a = [
- longlonglonglongItem1longlonglonglongItem1,
- longlonglonglongItem1longlonglonglongItem2,
- longlonglonglongItem1longlonglonglongItem3,
-];
+
"#;
let syntax = SourceType::tsx();
diff --git a/crates/rome_js_formatter/tests/specs/jsx/attributes.jsx b/crates/rome_js_formatter/tests/specs/jsx/attributes.jsx
index 562347d00b3..0cda6aea289 100644
--- a/crates/rome_js_formatter/tests/specs/jsx/attributes.jsx
+++ b/crates/rome_js_formatter/tests/specs/jsx/attributes.jsx
@@ -68,3 +68,9 @@ const a = Delete
;
+
+
diff --git a/crates/rome_js_formatter/tests/specs/jsx/attributes.jsx.snap b/crates/rome_js_formatter/tests/specs/jsx/attributes.jsx.snap
index 195c9a44cf7..ac746b183df 100644
--- a/crates/rome_js_formatter/tests/specs/jsx/attributes.jsx.snap
+++ b/crates/rome_js_formatter/tests/specs/jsx/attributes.jsx.snap
@@ -77,6 +77,12 @@ const a =
;
+
+
```
@@ -176,6 +182,14 @@ const a = (
);
+;
+
## Unimplemented nodes/tokens
@@ -187,6 +201,7 @@ const a = (
10: "ui-monospace,SFMono-Regular,SF Mono,Consolas,Liberation Mono,Menlo,monospace",
30: "ui-monospace,SFMono-Regular,SF Mono,Consolas,Liberation Mono,Menlo,monospace",
+ 85: veryLongConditionZzzzzzzzzzzzzzzzzveryLongConditionZzzzzzzzzzzzzzzzzveryLongConditionZzzzzzzzzzzzzzzzz,
```