From aa638b1638a8d23fd6dd7dfaaa48719c2c3e553b Mon Sep 17 00:00:00 2001
From: Victorien ELVINGER <victorien@elvinger.fr>
Date: Fri, 16 Jul 2021 12:30:32 +0200
Subject: [PATCH] feat(lint): add missing TypeScript types (#1646)

---
 .../lint/rules/js/noUndeclaredVariables.ts    | 130 ++++++++++++++----
 1 file changed, 105 insertions(+), 25 deletions(-)

diff --git a/internal/compiler/lint/rules/js/noUndeclaredVariables.ts b/internal/compiler/lint/rules/js/noUndeclaredVariables.ts
index 374fb63b2ec..4d4d8574a3b 100644
--- a/internal/compiler/lint/rules/js/noUndeclaredVariables.ts
+++ b/internal/compiler/lint/rules/js/noUndeclaredVariables.ts
@@ -35,40 +35,120 @@ const BROWSER_VARIABLES_SET = new Set([
 
 // This is gross...
 const TS_VARIABLES_SET = new Set([
-	"MethodDecorator",
-	"ParameterDecorator",
-	"PromiseConstructorLike",
-	"PromiseLike",
-	"Promise",
+	"AggregateErrorConstructor",
+	"ArrayBufferConstructor",
+	"ArrayBufferLike",
+	"ArrayBufferTypes",
+	"ArrayBufferView",
+	"ArrayConstructor",
 	"ArrayLike",
-	"ReadonlyArray",
-	"Partial",
-	"Required",
-	"Readonly",
-	"Pick",
-	"Record",
+	"AsyncGenerator",
+	"AsyncGeneratorFunction",
+	"AsyncGeneratorFunctionConstructor",
+	"AsyncIterable",
+	"AsyncIterableIterator",
+	"AsyncIterator",
+	"Atomics",
+	"BigInt64ArrayConstructor",
+	"BigIntConstructor",
+	"BigIntToLocaleStringOptions",
+	"BigUint64ArrayConstructor",
+	"BooleanConstructor",
+	"BufferEncoding",
+	"BufferSource",
+	"CallableFunction",
+	"Capitalize",
+	"ClassDecorator",
+	"ConcatArray",
+	"Console",
+	"ConstructorParameters",
+	"DataViewConstructor",
+	"DateConstructor",
+	"ErrorConstructor",
+	"EvalErrorConstructor",
 	"Exclude",
 	"Extract",
-	"Omit",
-	"NonNullable",
-	"Parameters",
-	"ConstructorParameters",
-	"ReturnType",
+	"FinalizationRegistryConstructor",
+	"FlatArray",
+	"Float32ArrayConstructor",
+	"Float64ArrayConstructor",
+	"FunctionConstructor",
+	"Generator",
+	"GeneratorFunction",
+	"GeneratorFunctionConstructor",
+	"IArguments",
+	"ImportMeta",
 	"InstanceType",
-	"ThisType",
-	"NodeJS",
-	"NodeRequire",
+	"Int16ArrayConstructor",
+	"Int32ArrayConstructor",
+	"Int8ArrayConstructor",
 	"Iterable",
 	"IterableIterator",
-	"ArrayBufferView",
 	"Iterator",
+	"IteratorResult",
+	"IteratorReturnResult",
+	"IteratorYieldResult",
+	"Lowercase",
+	"MapConstructor",
+	"MethodDecorator",
+	"NewableFunction",
+	"NodeJS",
+	"NodeRequire",
+	"NonNullable",
+	"NumberConstructor",
+	"ObjectConstructor",
+	"Omit",
+	"OmitThisParameter",
+	"ParameterDecorator",
+	"Parameters",
+	"Partial",
+	"Pick",
+	"PromiseConstructor",
+	"PromiseConstructorLike",
+	"PromiseFulfilledResult",
+	"PromiseLike",
+	"PromiseRejectedResult",
+	"PromiseSettledResult",
+	"PropertyDecorator",
+	"PropertyDescriptor",
+	"PropertyDescriptorMap",
+	"PropertyKey",
+	"ProxyConstructor",
+	"ProxyHandler",
+	"RangeErrorConstructor",
+	"Readonly",
+	"ReadonlyArray",
+	"ReadonlyMap",
+	"ReadonlySet",
+	"Record",
+	"ReferenceErrorConstructor",
+	"RegExpConstructor",
+	"RegExpExecArray",
+	"RegExpMatchArray",
+	"RequestInit",
+	"Required",
+	"ReturnType",
+	"SetConstructor",
+	"SharedArrayBufferConstructor",
+	"StringConstructor",
+	"SymbolConstructor",
+	"SyntaxErrorConstructor",
 	"TemplateStringsArray",
-	"BufferEncoding",
-	"Console",
 	"Thenable",
-	"ArrayBufferLike",
-	"BufferSource",
-	"RequestInit",
+	"ThisParameterType",
+	"ThisType",
+	"TypeErrorConstructor",
+	"TypedPropertyDescriptor",
+	"URIErrorConstructor",
+	"Uint16ArrayConstructor",
+	"Uint32ArrayConstructor",
+	"Uint8ArrayConstructor",
+	"Uint8ClampedArrayConstructor",
+	"Uncapitalize",
+	"Uppercase",
+	"WeakMapConstructor",
+	"WeakRefConstructor",
+	"WeakSetConstructor",
 ]);
 
 export default createVisitor({