rome ci does not care about rome.json

[anonrig]

Environment information

node 18.8.0
macos latest version
rome 0.9.0 - installed using pnpm add -D rome@next

What happened?

npm run format:ci which is rome ci . does not care about rome.json configuration.

there isn't any clear way of running formatter on CI and throwing errors if it fails.

{
  "formatter": {
    "indentStyle": "space",
    "indentSize": 2
  },
  "linter": {
    "enabled": false
  }
}

Expected result

It should care linter enabled false configuration and not check for linting.

Code of Conduct

• I agree to follow Rome's Code of Conduct

[MichaReiser]

It seems that the ci command doesn't respect the configuration all together as it also doesn't take formatting options into account. @ematipico @leops would you be able to have a look and I think we should consider doing a follow up release with the fix included

[anonrig]

You can reproduce the same behaviour with this pull request: anonrig/fast-querystring#11

[leops]

I've noted two slightly unrelated bugs here:

• From what I can see the configuration file is correctly being loaded (changing the indent size / style in the rome.json works as expected for instance), but the ci command is hard-coded to call into both the formatter and the linter and doesn't respect the enabled setting for either tool. This should be fixed at two points: the Workspace should return an error the the linting or formatting methods are called but the corresponding tool is disabled, and the CLI should not attempt to call into these methods in the first place if the supports_feature method has returned false / Some(_)
• The CLI flags like --indent-style are being ignored, specifically they get read into a WorkspaceSettings struct but this information never gets used or applied anywhere