Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

📎 Remove WASM dependencies from rome package #3482

Closed
MichaReiser opened this issue Oct 25, 2022 · 2 comments · Fixed by #3483
Closed

📎 Remove WASM dependencies from rome package #3482

MichaReiser opened this issue Oct 25, 2022 · 2 comments · Fixed by #3483
Labels
task A task, an action that needs to be performed
Milestone
10.0.0

Comments

@MichaReiser
Copy link
Contributor

MichaReiser commented Oct 25, 2022 •
edited
Loading

Description

Remove the wasm dependencies from the rome and backend-jsonrpc npm package

  • @rometools/wasm-bundler
  • @rometools/wasm-nodejs
  • @rometools/wasm-web

These dependencies are no longer required now that the js-api is in its own package.
This reduces the size of the rome package including its dependencies from 20 to 12mb
@MichaReiser MichaReiser added the task A task, an action that needs to be performed label Oct 25, 2022
@MichaReiser MichaReiser added this to the 10.0.0 milestone Oct 25, 2022
@ematipico
Copy link
Contributor

The task should be "Move WASM dependencies from rome to @rometools/js-api" :)

@MichaReiser
Copy link
Contributor Author

The task should be "Move WASM dependencies from rome to @rometools/js-api" :)

Oh, I didn't know that. Since you're the expert. Would you mind updating the task with what must be done?

@ematipico ematipico changed the title 📎 Remove WASM dependencies from rome package 📎 Move WASM dependencies from rome package to @rometools/js-api Oct 25, 2022
@MichaReiser MichaReiser changed the title 📎 Move WASM dependencies from rome package to @rometools/js-api 📎 Remove WASM dependencies from rome package Oct 25, 2022
@ematipico ematipico mentioned this issue Oct 25, 2022
Merged
@ematipico ematipico moved this to Done in Rome 2022 Oct 25, 2022
@MichaReiser MichaReiser mentioned this issue Nov 8, 2022
Closed
13 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
task A task, an action that needs to be performed
Projects
Rome 2022
Status: Done
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

chore(rome): remove WASM pacakges from optional dependencies rome/tools
2 participants
@ematipico @MichaReiser