Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

☂️ v10 release #3575

Closed
13 tasks done
sebmck opened this issue Nov 6, 2022 · 5 comments
Closed
13 tasks done

☂️ v10 release #3575

sebmck opened this issue Nov 6, 2022 · 5 comments
Labels
umbrella Issue to track a collection of other issues
Milestone

Comments

@sebmck
Copy link
Contributor

sebmck commented Nov 6, 2022

Before Release Day

Benchmark

  • Merge benchmark branch
  • Use M1 Macbook performance numbers in all public benchmark results
  • Ensure benchmark folder has a README with instructions to reproduce

rome.tools

  • Update blog cover photo
  • Setup Google analytics

docs.rome.tools

  • Remove docs "back chevron" in favor of a navigation dropdown
  • Finish editor documentation
  • Setup Google analytics

On Release Day

Publicize

@sebmck sebmck added the umbrella Issue to track a collection of other issues label Nov 6, 2022
@Boshen
Copy link
Contributor

Boshen commented Nov 8, 2022

npm instal rome
added 5 packages

This doesn't look right, it should be only 1 package.

Test:

~/github/rome ❯ npm install rome --no-audit

added 1 package in 2s

~/github/rome ❯ ls -a node_modules/
.                  ..                 .bin               .package-lock.json rome

@sebmck
Copy link
Contributor Author

sebmck commented Nov 8, 2022

Try rome@next:

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: @rometools/cli-win32-x64@0.10.1-next (node_modules/rome/node_modules/@rometools/cli-win32-x64):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for @rometools/cli-win32-x64@0.10.1-next: wanted {"os":"win32","arch":"x64"} (current: {"os":"darwin","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: @rometools/cli-linux-arm64@0.10.1-next (node_modules/rome/node_modules/@rometools/cli-linux-arm64):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for @rometools/cli-linux-arm64@0.10.1-next: wanted {"os":"linux","arch":"arm64"} (current: {"os":"darwin","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: @rometools/cli-win32-arm64@0.10.1-next (node_modules/rome/node_modules/@rometools/cli-win32-arm64):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for @rometools/cli-win32-arm64@0.10.1-next: wanted {"os":"win32","arch":"arm64"} (current: {"os":"darwin","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: @rometools/cli-linux-x64@0.10.1-next (node_modules/rome/node_modules/@rometools/cli-linux-x64):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for @rometools/cli-linux-x64@0.10.1-next: wanted {"os":"linux","arch":"x64"} (current: {"os":"darwin","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: @rometools/cli-darwin-arm64@0.10.1-next (node_modules/rome/node_modules/@rometools/cli-darwin-arm64):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for @rometools/cli-darwin-arm64@0.10.1-next: wanted {"os":"darwin","arch":"arm64"} (current: {"os":"darwin","arch":"x64"})
npm WARN foo@1.0.0 No description
npm WARN foo@1.0.0 No repository field.

+ rome@0.10.1-next
added 5 packages

I edited my screenshot to remove the @next tag. Next release won't need it.

@Boshen
Copy link
Contributor

Boshen commented Nov 8, 2022

~/github/rome ❯ ls node_modules/@rometools/
cli-darwin-x64 wasm-bundler   wasm-nodejs    wasm-web

I see, we now have these guys.

@MichaReiser
Copy link
Contributor

MichaReiser commented Nov 8, 2022

npm instal rome

added 5 packages

This doesn't look right, it should be only 1 package.

Test:


~/github/rome ❯ npm install rome --no-audit



added 1 package in 2s



~/github/rome ❯ ls -a node_modules/

.                  ..                 .bin               .package-lock.json rome

Hmm, I thought that was fixed. Let me have a look at it

#3482

@MichaReiser
Copy link
Contributor

MichaReiser commented Nov 8, 2022

Verified: this if fixed in the latest nightly version

❯ npm install rome@nightly

added 2 packages, and audited 4 packages in 664ms

Size of node_modules: ~11.4MB
There are two packages: One is the node wrapper, and the other is the native binary for the platform

@MichaReiser MichaReiser added this to the 10.0.0 milestone Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
umbrella Issue to track a collection of other issues
Projects
None yet
Development

No branches or pull requests

3 participants