Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

noThisBeforeSuper, no-this-before-super #3983

Closed
Tracked by #3953
ematipico opened this issue Dec 6, 2022 · 5 comments
Closed
Tracked by #3953

noThisBeforeSuper, no-this-before-super #3983

ematipico opened this issue Dec 6, 2022 · 5 comments
Assignees
@Conaclos
Labels
I-Difficult Implementation: requires deep knowledge of the tools and the problem.

Comments

@ematipico
Copy link
Contributor

ematipico commented Dec 6, 2022 •
edited
Loading

https://eslint.org/docs/latest/rules/no-this-before-super
@ematipico ematipico mentioned this issue Dec 6, 2022
Open
30 tasks
@ematipico ematipico changed the title https://eslint.org/docs/latest/rules/no-this-before-super noThisBeforeSuper, no-this-before-super Dec 6, 2022
@ematipico ematipico added the I-Difficult Implementation: requires deep knowledge of the tools and the problem. label Dec 6, 2022
@ematipico
Copy link
Contributor Author

This rule requires traversing the code paths of the constructor and checking the range of super and this..

@Conaclos
Copy link
Contributor

Conaclos commented Dec 6, 2022

I would like to implement this rule. :)

@github-actions
Copy link

👋 @rome/staff please triage this issue by adding one of the following labels: S-Bug: confirmed, S-Planned , S-Wishlist or umbrella

@ematipico
Copy link
Contributor Author

I believe this rule has been implemented by #4017

@leops could you please confirm? And if so, could you please the issue?

@leops
Copy link
Contributor

leops commented Dec 21, 2022

Ah yes that's implemented as part of the control flow analysis in noUnreachableSuper

@leops leops closed this as completed Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Conaclos Conaclos

Labels
I-Difficult Implementation: requires deep knowledge of the tools and the problem.
Projects
ESlint recommended rules
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ematipico @leops @Conaclos