Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

📎 Support extensible config via "extends" property #4038

Closed
marcalexiei opened this issue Dec 11, 2022 · 3 comments · Fixed by #4572
Closed

📎 Support extensible config via "extends" property #4038

marcalexiei opened this issue Dec 11, 2022 · 3 comments · Fixed by #4572
Assignees
Labels
A-Project Area: project configuration and loading Help wanted Help would be really appreciated I-Normal Implementation: normal understanding of the tool and awareness S-Planned Status: planned by the team, but not in the short term task A task, an action that needs to be performed
Milestone

Comments

@marcalexiei
Copy link

Description

Support extends key inside configuration file in order to provide the ability to re-use configuration among different repositories.

References:

@marcalexiei marcalexiei added the task A task, an action that needs to be performed label Dec 11, 2022
@ematipico ematipico added A-Project Area: project configuration and loading S-Planned Status: planned by the team, but not in the short term labels Dec 12, 2022
@ematipico ematipico added the Help wanted Help would be really appreciated label May 8, 2023
@ematipico
Copy link
Contributor

Bumping this. After the 12.1.0 release, I think we could start implementing it.

We have good diagnostics and a great awareness of the configuration file now. Of course, the extends will be limited only to physical paths:

Yes ✅

{
	"extends": ["./formatter.json"],
}

No ❌

{
	"extends": ["@somelibrary/hey"],
}

cc @rome/core-contributors if you're interested of if there's someone interested

@ematipico ematipico added the I-Normal Implementation: normal understanding of the tool and awareness label May 8, 2023
@unvalley unvalley self-assigned this May 13, 2023
@ematipico ematipico added this to the v13.0.0 milestone Jun 15, 2023
@ematipico ematipico assigned ematipico and unassigned unvalley Jun 15, 2023
@Nikola-Milovic
Copy link

No x
{
"extends": ["@somelibrary/hey"],
}

@ematipico does this mean we still can't have a shared package with rome config in monorepos and use it to extend? Especially in larger monorepos I'd love to have shared rome config across all projects. I currently use this approach for tsconfigs for example

@ematipico
Copy link
Contributor

ematipico commented Aug 13, 2023

We're clearly aware of the limitation, but Rome can't resolve dependencies yet. Hopefully soon we will be able to implement it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Project Area: project configuration and loading Help wanted Help would be really appreciated I-Normal Implementation: normal understanding of the tool and awareness S-Planned Status: planned by the team, but not in the short term task A task, an action that needs to be performed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants