Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

📎 New rome lint command #4452

Closed
ematipico opened this issue May 9, 2023 · 2 comments · Fixed by #4629
Closed

📎 New rome lint command #4452

ematipico opened this issue May 9, 2023 · 2 comments · Fixed by #4629
Assignees
Labels
A-CLI Area: CLI Help wanted Help would be really appreciated I-Normal Implementation: normal understanding of the tool and awareness
Milestone

Comments

@ematipico
Copy link
Contributor

Description

Rome has a command called rome check, which does multiple things:

  • check formatting
  • checks linting
  • check imports

And it will contain more in the future. To avoid possible friction in the future, I think Rome should ship a new command called rome lint, which only checks the code against lint rules. It will also have -apply and --apply-unsafe arguments.

@ematipico ematipico added the A-CLI Area: CLI label May 9, 2023
@ematipico ematipico added this to the v12.2.0 milestone May 9, 2023
@ematipico ematipico added Help wanted Help would be really appreciated I-Normal Implementation: normal understanding of the tool and awareness labels May 9, 2023
@Conaclos
Copy link
Contributor

Rome has a command called rome check, which does multiple things:

  • check formatting

I think that rome check does not check formatting, in contrast to rome ci.
Do you think that it should? What could be the difference with rome ci?

Otherwise, I like the idea.

@ematipico
Copy link
Contributor Author

Rome has a command called rome check, which does multiple things:

  • check formatting

I think that rome check does not check formatting, in contrast to rome ci.

I am about to change that logic (I think it is a bug), but yes it does format. It also checks the imports.

Do you think that it should? What could be the difference with rome ci?

The CI commands wouldn't allow to change any code, it would show the diagnostics on GitHub (check discussions proposal), etc.

Otherwise, I like the idea.

Nice! If you want, I can guide you :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-CLI Area: CLI Help wanted Help would be really appreciated I-Normal Implementation: normal understanding of the tool and awareness
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants