Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 Rome 12.1.0 does not respect rules configuration #4488

Closed
1 task done
nstepien opened this issue May 16, 2023 · 2 comments
Closed
1 task done

🐛 Rome 12.1.0 does not respect rules configuration #4488

nstepien opened this issue May 16, 2023 · 2 comments
Labels
S-To triage Status: user report of a possible bug that needs to be triaged

Comments

@nstepien
Copy link
Contributor

Environment information

CLI:
  Version:                      12.1.0
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           windows

Environment:
  ROME_LOG_DIR:                 unset
  NO_COLOR:                     unset
  TERM:                         unset
  JS_RUNTIME_VERSION:           "v20.1.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/9.6.6"

Rome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    true
  VCS disabled:                 true

Workspace:
  Open Documents:               0

Discovering running Rome servers...

Running Rome Server: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i The client isn't connected to any server but rage discovered this running Rome server.

Server:
  Version:                      12.1.0
  Name:                         rome_lsp
  CPU Architecture:             x86_64
  OS:                           windows

Workspace:
  Open Documents:               0

Other Active Server Workspaces:

Workspace:
  Open Documents:               1
  Client Name:                  Visual Studio Code
  Client Version:               1.78.2

Rome Server Log:

! Please review the content of the log file before sharing it publicly as it may contain sensitive information:
  * Path names that may reveal your name, a project name, or the name of your employer.
  * Source code

< "Comment is too long" >

What happened?

With this config:

{
  "files": {
    "ignore": ["./coverage/**/*", "./dist/**/*", "./lib/**/*", "*.json"]
  },
  "linter": {
    "rules": {
      "recommended": false,
      "a11y": {},
      "complexity": {},
      "correctness": {},
      "performance": {},
      "security": {},
      "style": {},
      "suspicious": {}
    }
  }
}

ALl the recommended rules are enabled when I run rome check ., even though recommended is set to `false.

If I remove these lines then the rules do not get unexpectedly re-enabled:

      "a11y": {},
      "complexity": {},
      "correctness": {},
      "performance": {},
      "security": {},
      "style": {},
      "suspicious": {}

Expected result

The rules configuration should be respected as defiend.

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@nstepien nstepien added the S-To triage Status: user report of a possible bug that needs to be triaged label May 16, 2023
@Conaclos
Copy link
Contributor

This is certainly related to #4479.

@ematipico
Copy link
Contributor

Duplicate of #4479

@ematipico ematipico marked this as a duplicate of #4479 May 16, 2023
@ematipico ematipico closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S-To triage Status: user report of a possible bug that needs to be triaged
Projects
None yet
Development

No branches or pull requests

3 participants