Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 --apply-unsafe and --apply CLI arguments cause errors not to be returned #4569

Closed
1 task done
EvHaus opened this issue Jun 14, 2023 · 0 comments · Fixed by #4668
Closed
1 task done

🐛 --apply-unsafe and --apply CLI arguments cause errors not to be returned #4569

EvHaus opened this issue Jun 14, 2023 · 0 comments · Fixed by #4668
Labels
A-CLI Area: CLI enhancement New feature request or improvement to existing functionality
Milestone

Comments

@EvHaus
Copy link

EvHaus commented Jun 14, 2023

Environment information

CLI:
  Version:                      12.1.3
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  ROME_LOG_DIR:                 unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.2.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "pnpm/8.6.2"

Rome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

Discovering running Rome servers...

Incompatible Rome Server: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

ℹ Rage discovered this running server using an incompatible version of Rome.

Server:
  Version:                      12.1.0

What happened?

As discussed on Discord, I noticed that when I run rome check --apply-unsafe . and there are errors, the output says:

Fixes applied to the file, but there a still diagnostics to address.

But if I run rome check . then it shows me the actual errors.

It would be great if there was a way for the CLI to show both of those behaviours together, ie. I want the fixes to be applied but also errors for what couldn't be fixed shown too.

This is how ESLint works.

Expected result

CLI output would show remaining errors that couldn't be auto-fixed.

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@EvHaus EvHaus added the S-To triage Status: user report of a possible bug that needs to be triaged label Jun 14, 2023
@ematipico ematipico added enhancement New feature request or improvement to existing functionality A-CLI Area: CLI and removed S-To triage Status: user report of a possible bug that needs to be triaged labels Jun 14, 2023
@ematipico ematipico added this to the v13.0.0 milestone Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-CLI Area: CLI enhancement New feature request or improvement to existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants