From 5e1c47ed2687300d2a0de403bf051d66e473e8e3 Mon Sep 17 00:00:00 2001 From: Micha Reiser Date: Thu, 10 Nov 2022 12:27:59 +0100 Subject: [PATCH 1/5] fix(npm/js_api): Build workflow --- .github/workflows/release_js_api.yml | 7 ++++++- npm/js-api/.gitignore | 1 - 2 files changed, 6 insertions(+), 2 deletions(-) delete mode 100644 npm/js-api/.gitignore diff --git a/.github/workflows/release_js_api.yml b/.github/workflows/release_js_api.yml index 2f1e17cf6fe..55b41e4fd66 100644 --- a/.github/workflows/release_js_api.yml +++ b/.github/workflows/release_js_api.yml @@ -104,7 +104,7 @@ jobs: working-directory: npm/js-api run: | pnpm i - pnpm build + pnpm build - name: Upload JS API artifact uses: actions/upload-artifact@v3 @@ -133,6 +133,11 @@ jobs: with: node-version: 14.x registry-url: 'https://registry.npmjs.org' + - name: List dir + run: ls npm/js-api + + - name: Exit + run: exit 1 - name: Set release infos if: needs.build.outputs.prerelease == 'true' diff --git a/npm/js-api/.gitignore b/npm/js-api/.gitignore deleted file mode 100644 index 77738287f0e..00000000000 --- a/npm/js-api/.gitignore +++ /dev/null @@ -1 +0,0 @@ -dist/ \ No newline at end of file From 9408677f95e5df749e7ae4db698dcd4a6e0db5fb Mon Sep 17 00:00:00 2001 From: Micha Reiser Date: Thu, 10 Nov 2022 14:09:49 +0100 Subject: [PATCH 2/5] Temporarily remove branch protection --- .github/workflows/release_js_api.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release_js_api.yml b/.github/workflows/release_js_api.yml index 55b41e4fd66..6be0cc44810 100644 --- a/.github/workflows/release_js_api.yml +++ b/.github/workflows/release_js_api.yml @@ -118,7 +118,7 @@ jobs: name: Publish runs-on: ubuntu-latest needs: build - environment: npm-publish + # environment: npm-publish steps: - uses: actions/checkout@v3 From d935a9cc093a6273dd4df24c597717d401583783 Mon Sep 17 00:00:00 2001 From: Micha Reiser Date: Thu, 10 Nov 2022 14:17:09 +0100 Subject: [PATCH 3/5] Fix dependencies --- .github/workflows/release_js_api.yml | 2 +- npm/js-api/package.json | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/release_js_api.yml b/.github/workflows/release_js_api.yml index 6be0cc44810..d4988afd7ac 100644 --- a/.github/workflows/release_js_api.yml +++ b/.github/workflows/release_js_api.yml @@ -126,7 +126,7 @@ jobs: uses: actions/download-artifact@v3 with: name: js-api - path: npm + path: npm/js-api - name: Install Node.js uses: actions/setup-node@v3 diff --git a/npm/js-api/package.json b/npm/js-api/package.json index 28b29dd2d15..abcdadbf379 100644 --- a/npm/js-api/package.json +++ b/npm/js-api/package.json @@ -40,9 +40,9 @@ "rome": "../rome" }, "peerDependencies": { - "rome": "^0.10.1-next", - "@rometools/wasm-nodejs": "^0.10.1-next", - "@rometools/backend-jsonrpc": "^0.10.1-next" + "rome": "^10.0.0", + "@rometools/wasm-nodejs": "^10.0.0", + "@rometools/backend-jsonrpc": "^10.0.0" }, "peerDependenciesMeta": { "rome": { From a4dc0ba878506eeadbcda0fe0fe7cabb20d19aa1 Mon Sep 17 00:00:00 2001 From: Micha Reiser Date: Thu, 10 Nov 2022 14:25:22 +0100 Subject: [PATCH 4/5] Fix extraction path --- .github/workflows/release_js_api.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release_js_api.yml b/.github/workflows/release_js_api.yml index d4988afd7ac..3bd380aa398 100644 --- a/.github/workflows/release_js_api.yml +++ b/.github/workflows/release_js_api.yml @@ -126,7 +126,7 @@ jobs: uses: actions/download-artifact@v3 with: name: js-api - path: npm/js-api + path: npm/js-api/dist - name: Install Node.js uses: actions/setup-node@v3 From 59a4ca9c4139ed6d0a08db2e84bc66f1c520f090 Mon Sep 17 00:00:00 2001 From: Micha Reiser Date: Thu, 10 Nov 2022 14:34:01 +0100 Subject: [PATCH 5/5] Undo testing changes & pump version --- .github/workflows/release_js_api.yml | 7 +------ npm/js-api/package.json | 4 ++-- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/.github/workflows/release_js_api.yml b/.github/workflows/release_js_api.yml index 3bd380aa398..81df7d541c0 100644 --- a/.github/workflows/release_js_api.yml +++ b/.github/workflows/release_js_api.yml @@ -118,7 +118,7 @@ jobs: name: Publish runs-on: ubuntu-latest needs: build - # environment: npm-publish + environment: npm-publish steps: - uses: actions/checkout@v3 @@ -133,11 +133,6 @@ jobs: with: node-version: 14.x registry-url: 'https://registry.npmjs.org' - - name: List dir - run: ls npm/js-api - - - name: Exit - run: exit 1 - name: Set release infos if: needs.build.outputs.prerelease == 'true' diff --git a/npm/js-api/package.json b/npm/js-api/package.json index 9d336e6438c..c31985b601b 100644 --- a/npm/js-api/package.json +++ b/npm/js-api/package.json @@ -1,6 +1,6 @@ { "name": "@rometools/js-api", - "version": "0.1.1", + "version": "0.1.2", "description": "JavaScript APIs for the Rome package", "scripts": { "tsc": "tsc --noEmit", @@ -55,4 +55,4 @@ "optional": true } } -} \ No newline at end of file +}