From 028b363fe54986d8e0192f81f7bcd5fed93c6879 Mon Sep 17 00:00:00 2001 From: nissy-dev Date: Sun, 30 Apr 2023 22:11:16 +0900 Subject: [PATCH 1/2] fix: remove flase positive --- .../src/semantic_analyzers/nursery/use_camel_case.rs | 2 +- .../tests/specs/nursery/useCamelCase/useCamelCase.jsx | 4 +++- .../tests/specs/nursery/useCamelCase/useCamelCase.jsx.snap | 3 +++ 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/crates/rome_js_analyze/src/semantic_analyzers/nursery/use_camel_case.rs b/crates/rome_js_analyze/src/semantic_analyzers/nursery/use_camel_case.rs index 220d4b409f8..6286b1bd221 100644 --- a/crates/rome_js_analyze/src/semantic_analyzers/nursery/use_camel_case.rs +++ b/crates/rome_js_analyze/src/semantic_analyzers/nursery/use_camel_case.rs @@ -76,7 +76,7 @@ fn is_non_camel_ok(binding: &JsIdentifierBinding, model: &SemanticModel) -> Opti }; Some(is_ok) } - JS_FUNCTION_DECLARATION => { + JS_FUNCTION_DECLARATION | JS_FUNCTION_EXPORT_DEFAULT_DECLARATION => { if binding.is_exported(model) { return Some(true); } diff --git a/crates/rome_js_analyze/tests/specs/nursery/useCamelCase/useCamelCase.jsx b/crates/rome_js_analyze/tests/specs/nursery/useCamelCase/useCamelCase.jsx index 8ea15861a1b..95aee0912f0 100644 --- a/crates/rome_js_analyze/tests/specs/nursery/useCamelCase/useCamelCase.jsx +++ b/crates/rome_js_analyze/tests/specs/nursery/useCamelCase/useCamelCase.jsx @@ -1,3 +1,5 @@ // valid function Component() {} -foo \ No newline at end of file +foo +export function ExportComponent() {} +export default function ExportDefaultComponent() {} diff --git a/crates/rome_js_analyze/tests/specs/nursery/useCamelCase/useCamelCase.jsx.snap b/crates/rome_js_analyze/tests/specs/nursery/useCamelCase/useCamelCase.jsx.snap index 41e6e8ec945..20f55b12e8a 100644 --- a/crates/rome_js_analyze/tests/specs/nursery/useCamelCase/useCamelCase.jsx.snap +++ b/crates/rome_js_analyze/tests/specs/nursery/useCamelCase/useCamelCase.jsx.snap @@ -7,6 +7,9 @@ expression: useCamelCase.jsx // valid function Component() {} foo +export function ExportComponent() {} +export default function ExportDefaultComponent() {} + ``` From 51ed256f54ef3165c16f03c96e5288530bbf731a Mon Sep 17 00:00:00 2001 From: nissy-dev Date: Sun, 30 Apr 2023 22:27:15 +0900 Subject: [PATCH 2/2] docs: update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e8cbf402b28..be1fd8acf4f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,7 @@ output. [#4405](https://github.com/rome/tools/pull/4405) when there are breaking changes. - Fix [#4348](https://github.com/rome/tools/issues/4348) that caused [`noNonNullAssertion`](https://docs.rome.tools/lint/rules/nononnullassertion/) to emit incorrect code action - Fix [#4410](https://github.com/rome/tools/issues/4410) that caused [`useButtonType`](https://docs.rome.tools/lint/rules/usebuttontype/) to miss some cases +- Fix false positive diagnostics that [`useCamelCase`](https://docs.rome.tools/lint/rules/usecamelcase/) caused to default exported components ### Configuration ### Editors