Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100% test coverage #172

Open
LincolnPuzey opened this issue Apr 1, 2021 · 1 comment
Open

100% test coverage #172

LincolnPuzey opened this issue Apr 1, 2021 · 1 comment
Assignees
Milestone

Comments

@LincolnPuzey
Copy link
Collaborator

there is only 1 uncovered line - either
a) remove it - breaking change.
b) add a test covering it.

@LincolnPuzey LincolnPuzey added this to the 2.0.0 milestone Apr 1, 2021
@LincolnPuzey LincolnPuzey self-assigned this Apr 1, 2021
@2019342a
Copy link
Contributor

Is option a a breaking change? Looking at the line in question, it seems to have been introduced in #108 and by the discussion on the PR, it looks like it was a fix for Django less than 1.10.

Removing this

if field.get_attname() in instance.get_deferred_fields():
    continue

does not make the test fail (which I assume is what this test is trying to cover)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants