Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] (alpha) network error when loading rom for emulatorjs #1110

Open
sargunv opened this issue Aug 23, 2024 · 21 comments
Open

[Bug] (alpha) network error when loading rom for emulatorjs #1110

sargunv opened this issue Aug 23, 2024 · 21 comments
Labels
bug Something isn't working

Comments

@sargunv
Copy link

sargunv commented Aug 23, 2024

RomM version
3.5.0 alpha 1

Describe the bug

When I try to play a ROM, I get a network error. Checking dev tools, I see a 403 on the HEAD request to the rom file.

To Reproduce

Play any rom

Expected behavior

The rom loads and plays

Screenshots
If applicable, add screenshots to help explain your problem.

CleanShot 2024-08-22 at 23 25 27@2x

Desktop (please complete the following information):

  • OS: macOS
  • Browser Chrome
  • Version 127.0.6533.120

Additional context

I installed this alpha because I saw #1086 is included and wanted to try playing a game in the browser.

@sargunv sargunv added the bug Something isn't working label Aug 23, 2024
@sargunv sargunv changed the title [Bug] 3.5.0 alpha 1: network error when loading rom for emulatorjs [Bug] (alpha) network error when loading rom for emulatorjs Aug 23, 2024
@sargunv
Copy link
Author

sargunv commented Aug 23, 2024

Relevant log lines for the request that's 403ing:

172.18.0.1:0 - "HEAD /api/roms/1403/content/ChuChu%20Rocket%21%20%28USA%29%20%28En%2CJa%2CFr%2CDe%2CEs%29.gba HTTP/1.0" 200
INFO:	  [nginx][2024-08-23 08:51:55]	172.18.0.5 - - "HEAD /api/roms/1403/content/ChuChu%20Rocket!%20(USA)%20(En,Ja,Fr,De,Es).gba HTTP/1.1" 403 0 "https://romm.home.sargunv.dev/rom/1403/ejs" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/127.0.0.0 Safari/537.36" rt=0.117 uct="0.000" uht="0.117" urt="0.117"
2024/08/23 08:51:55 [error] 28#28: *2201 open() "/romm/library/roms/gba/ChuChu Rocket! (USA) (En,Ja,Fr,De,Es).gba" failed (13: Permission denied), client: 172.18.0.5, server: localhost, request: "HEAD /api/roms/1403/content/ChuChu%20Rocket!%20(USA)%20(En,Ja,Fr,De,Es).gba HTTP/1.1", upstream: "http://unix:/tmp/gunicorn.sock/api/roms/1403/content/ChuChu%20Rocket!%20(USA)%20(En,Ja,Fr,De,Es).gba", host: "romm.home.sargunv.dev", referrer: "https://romm.home.sargunv.dev/rom/1403/ejs"

Looks like permission was denied when opening the file for reading. Error persists even after chmod 777.

I tried to docker exec to a shell within the romm container, and can cat the same rom just okay, so file permissions should be good to read the file. Unsure why I'm getting permission denied

@iMartien
Copy link

Have nothing to add except that I have the exact same issue.

@NicksGhost
Copy link

I have exactly the same problem, did you solve it?

@iMartien
Copy link

iMartien commented Sep 1, 2024

No, still a problem in the latest non beta 3.5 version.

@Kengurugames
Copy link

Got the same issue permissions are set to 777. In my case the roms are on a NFS share. Access with docker exec works and permission also look fine. In v3.3.0 everything worked fine for me.

@gantoine
Copy link
Member

gantoine commented Sep 1, 2024

@adamantike Any chance this is related to the x-accel-redirect changes?

@Nomelas
Copy link

Nomelas commented Sep 2, 2024

looks like you're behind a proxy. What happens if you try to run the rom from the host:port directly?

@iMartien
Copy link

iMartien commented Sep 2, 2024

For me I’m running in docker, and no additional proxy is used.

@Kengurugames
Copy link

looks like you're behind a proxy. What happens if you try to run the rom from the host:port directly?

I tried to access it directly via port and it still got the same issue.

@adamantike
Copy link
Collaborator

adamantike commented Sep 6, 2024

I need to dig deeper into this, but something interesting I found, that could be the culprit of this issue, is that nginx is the only process that runs with user romm when the Docker container is configured to run with the root user (default). This is the related code.

That wouldn't explain this issue if permissions are actually set as 777, but they would need to be set like that (or, at least 444) for the entire path containing the rom, not only the rom file itself.

@sargunv
Copy link
Author

sargunv commented Sep 6, 2024

I was able to get this working by setting the user param on the docker container to the user:group owning the rom files (in my case, 1026:100). I'm still unsure why even chmod 777 didn't work but this did (maybe a parent directory on the path had stricter permissions)

@jonspraggins
Copy link

Nothing to add, but confirming the error occurs whether I go through a reverse proxy or by direct IP:port.
Even if the permissions assigned to the container have read/write to the rom folder and all objects within it.

Dropping some basic error details from the dev-tools Network Tab, but I imagine it adds zero to the conversation.
Note: I assign a different port than the standard.

Request URL:
http://192.168.1.5:8082/api/roms/39239/content/test-rom(U).zip
Request Method:
HEAD
Status Code:
403 Forbidden
Remote Address:
192.168.1.5:8082
Referrer Policy:
strict-origin-when-cross-origin

@Betonhaus
Copy link

I'm also having this issue

@Aiakio
Copy link

Aiakio commented Oct 6, 2024

Same here. [...] failed (13: Permission denied), [...], even though, everything was uploaded through the romm webinterface, i cant download any rom or use emulatorjs.

@Betonhaus
Copy link

I think I fixed it by defining the user and group that romm runs on, but I still have to have mariadb be root and using a docker volume

@Aiakio
Copy link

Aiakio commented Oct 6, 2024

Indeed user: 1036:100 fixed the downloads for me as well.

@PREngineer
Copy link

I am running it in a Synology NAS and I had the same issue when I specified the user (with proper permissions to the files in the NAS) in the environment variables like this:

PUID: 1026
PGID: 100

It was able to read all the files without issues but it just wouldn't play.


After switching to this:

user: '1026:100'

It works without issues now.

@iMartien
Copy link

I am running it in a Synology NAS and I had the same issue when I specified the user (with proper permissions to the files in the NAS) in the environment variables like this:

PUID: 1026 PGID: 100

It was able to read all the files without issues but it just wouldn't play.

After switching to this:

user: '1026:100'

It works without issues now.

I'm also running this on a Synology, but can't get it to work, can you share how I can set the "user" variable? I'm currently using the PUID and GUID variables, but when I remove those and replace it with user, it doesn't work... thanks!

@Aiakio
Copy link

Aiakio commented Oct 29, 2024

Im using docker compose. You can add the user line just like this:

---
services:
    romm:
        image: 'rommapp/romm:latest'
        container_name: romm
        restart: unless-stopped
        user: 1036:100
        environment:
            - DB_HOST=romm-db
[...]

I have 1036 because i created a user specifically for docker. You should not put your admin account there.

@PREngineer
Copy link

PREngineer commented Oct 29, 2024

I am running it in a Synology NAS and I had the same issue when I specified the user (with proper permissions to the files in the NAS) in the environment variables like this:
PUID: 1026 PGID: 100
It was able to read all the files without issues but it just wouldn't play.
After switching to this:
user: '1026:100'
It works without issues now.

I'm also running this on a Synology, but can't get it to work, can you share how I can set the "user" variable? I'm currently using the PUID and GUID variables, but when I remove those and replace it with user, it doesn't work... thanks!

Put the user line that I wrote in my comment right before the environment line.

user: '1026:100'
environment:

Make sure that the user and group match the user/group that you have given permission in Synology.

By default, the first account that you create (admin) is 1026 and 100.

I've recorded a tutorial that will be released in my YouTube channel this Saturday. Channel is Tech Byte Tips.

You can check that out later if you have questions.

In Synology, you will likely have issues with MariaDB if you are using Docker-Compose and DSM 7.2.

My video covers how to use the MariaDB in Package Manager instead.

@jonspraggins
Copy link

I am running it in a Synology NAS and I had the same issue when I specified the user (with proper permissions to the files in the NAS) in the environment variables like this:
PUID: 1026 PGID: 100
It was able to read all the files without issues but it just wouldn't play.
After switching to this:
user: '1026:100'
It works without issues now.

I'm also running this on a Synology, but can't get it to work, can you share how I can set the "user" variable? I'm currently using the PUID and GUID variables, but when I remove those and replace it with user, it doesn't work... thanks!

Put the user line that I wrote in my comment right before the environment line.

user: '1026:100'
environment:

Make sure that the user and group match the user/group that you have given permission in Synology.

By default, the first account that you create (admin) is 1026 and 100.

I've recorded a tutorial that will be released in my YouTube channel this Saturday. Channel is Tech Byte Tips.

You can check that out later if you have questions.

In Synology, you will likely have issues with MariaDB if you are using Docker-Compose and DSM 7.2.

My video covers how to use the MariaDB in Package Manager instead.

Confirmed. Adding the user parameter in the romm docker config granted access. Have a less privileged account that is used by docker to handle this. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests