-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] 524bytes files in every game i try to download #297
Comments
Did you just setup RomM or is this new behaviour you're seeing? And can you post the romm part of your docker-compose.yml (or docker command)? |
It was working at the beggining, but it isn't anymore. The only thing i have done is adding more games. I'm using an stack like this:
|
Ok your docker-compose looks right. How many games did you add, and how many do you have in total? Easiest things to try is
|
I have tried rebooting, and remade it from zero, and i get the same problem. |
Could you upload the 524 byte file here so I can take a look at it? |
Here it is: |
Ah! Ok could you try cleaning the cache in your browser (Application > Storage > Clear site data)? I also see the folder for your games is Sorry for all the questions, this is one of a hand full of bug reports so we're trying to figure out what tends to break and how best to report it. |
Tried clearing the site data, and same problem. Here is the config.yml: |
Well I'm out of ideas, we haven't released in a few months so I don't expect it's a code change that caused this. My instance has 1500+ files and downloads things as expected. I'm going to leave this pending and take another stab at it another time, but do let us know if you manage to fix it. |
Thanks either way! |
I have the same issue, each download has 524 MB one intresting thing: |
@stephanschorer 524 MB, KB or B? If it's bytes my guess is it's the same issue as above, which you can check by changing one of the file to html and opening it in the browser (you should see On that note, could you post the relevant part of your docker-compose file? |
@gantoine oh sorry I meant 512 B and yes there is this div inside docker-compose.yaml
as you can see the service is behind a reverse proxy I also tried to access the files inside the docker container, which works flawlessly. |
Ok great, that's the next thing I was going to ask. Can you try downloading a game using
Whether this works or not will help me narrow down where the issue resides. |
same output as before (rename to html file)
|
So the code has changed quite a bit since the last release, and I have a feeling #286 should resolve the issue. |
Alright I have a small update: I started experiencing this exact issue with my gamecube games. So I ran a "Complete Rescan" of my gamecube library, and it seems to be fixed. 🤷🏼 Worth a try, and please let me know if it works (or doesn't)! |
did you delete anything in advance? if not, that did not help in my case. Even tried to delete all local container files and performed a library rescan - that also did not work. I also tried some stuff, but I could never get a persistent behaviour.. I should mention that my roms are normally not stored locally on the host machine (I usually use rclone), but for that test all files were copied locally. I dont know whats wrong with that image, but I also encountered that sometimes the local directories (database and resources) are not recreated at container startup for some case.... if ofc I deleted them before |
@stephanschorer @outerwinnie We just released 1.9.1 which has the new zip/download mechanism. Could you upgrade to that version, then try downloading and let me know if it works/break? At the very lease we can rule out the download API as the root case, since it all changes. |
fresh container setup (all files deleted, image pulled, fresh library scan)
|
Im getting the same issue. Files 547 bytes. Will check later to do some troubelshooting since it have been working before for me. Dont know fully what is causing the issue. Im running as mentioned in unraid docker container behined a proxy. Will try to remove all games and just add one type to see if its any file paths that is causing the issue |
still same issue. removed all the roms except GBA but still only 547 bytes files. added switch games then it starts a download but keeps stacking ram never starts the download at all. running in 1.9.1 |
Solve the issue on my end. Tested giving it a standard folder adding just some small games under my docker disk instead of some share or so. This worked for me and i could start downloading files. The Then tested putting it under a different mount point in my main system. This worked as well. My guess is that it was some issue with the permission in my folder structure and when moving it to another folder solved it. If that makes sense |
That actually makes a ton of sense, and IMO RomM should do a better job of throwing errors when permissions are incorrect for download. I'm going to try to reproduce it this evening on my local system by messing with folder permissions. |
Ok I think I'm getting closer to the answer, here are some observations:
What's weird is the requests going out are identical, but the responses are completely different. I even tried clearing cache and everything, with no luck. 🤪 |
Getting the same issue. Stopt the docker for the night since i dont want it up as long as its not password protected and now i cant download so seems to be some kind of permission issue happening |
IT'S THE SERVICE WORKER IN FIREFOX! @Smurre95 Assuming you're on Firefox, (with RomM already open) head to The culprit seems to be |
You are correct my good sir tested on edge now and that worked tested with the solution on firefox you gave and seems to be the issue. interesting. But yeah now i have restarted the docker and it still works on edge so might have been a permission issue from the start on my end then. Cool. Lovely the new download update works good with it as well |
Mabey open up this bug once more since the merge was reverted ? |
@Smurre95 Thanks for the reminder, when we reverted the change we also updated the vite config. It now only caches assets of type workbox: {
globPatterns: ['**/*.{js,css,html,ico,png,svg}'],
navigateFallbackDenylist: [/^\/assets\/romm\/library/],
}, |
RomM version
1.8.4 - Docker
Describe the bug
When i press download, it downloads an 524bytes files, and not the whole game. I don't see any error in the docker log. If i try to download the file from the mobile, it downloads an html.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
It should download the complete file.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: