Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reexport compat bound issue? #105

Closed
thchr opened this issue Jan 4, 2021 · 2 comments
Closed

Reexport compat bound issue? #105

thchr opened this issue Jan 4, 2021 · 2 comments

Comments

@thchr
Copy link
Contributor

thchr commented Jan 4, 2021

I've been getting errors on CI for a week or two that are related to PrettyTables (e.g. this log). I looked into it today, and I realized that the build step is pulling in PrettyTables at version 0.1.0 rather than its most recent. I believe this is due to a compat conflict after a recent versioning update of Reexport.jl over in simonster/Reexport.jl#23.

Currently, the compat entry in PrettyTables.jl is set to 0.2.0; maybe it should just be pulled up to 1.0.0? If you agree, I can make a PR (it would be nice to fix; I think this could break a good deal of CI for packages that depend on PrettyTables).

[I'm honestly not completely sure if the compat entry here is to blame; for instance, my test CI works fine with PrettyTables, but only breaks when combined with Documenter.jl; there's some conflict that that is causing PrettyTables.jl to be downgraded.]

@nalimilan
Copy link

nalimilan commented Jan 4, 2021

If your package doesn't work with older PrettyTables versions, why not add a lower bounds to Project.toml? At least that will make the dependency error happen earlier.

Allowing PrettyTables to use Requires 1.0 is a good idea anyway.

@thchr
Copy link
Contributor Author

thchr commented Jan 4, 2021

If your package doesn't work with older PrettyTables versions, why not add a lower bounds to Project.toml? At least that will make the dependency error happen earlier.

This is a good point; I will do that..!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants