Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image cells in text backend #142

Closed
lorenzoh opened this issue Sep 22, 2021 · 1 comment
Closed

Image cells in text backend #142

lorenzoh opened this issue Sep 22, 2021 · 1 comment

Comments

@lorenzoh
Copy link
Contributor

So I have a basic version of a CustomTextCell working that uses ImageInTerminal.jl to draw images inside a table with a configurable maximum size. It looks like this:

image

Is there interest in having this in PrettyTables.jl? If there is, I'll open a pull request.

One note is that this would require taking on a dependency on either ImageInTerminal.jl itself or Requires.jl. Let me know what you think.

@ronisbr
Copy link
Owner

ronisbr commented Sep 22, 2021

Hi @lorenzoh !

This is a very nice usage of CustomTextCell API :)

We can add to PrettyTables.jl, but we must take care of some problems:

  1. Does the load time of the package increase? In this case, I think it is better to add dependency of Requires.jl instead of ImageInTerminal.jl.
  2. The custom cell supports cropping? Did you test with limited cell width and limited display size?
  3. Is the time to print the first cell degraded?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants