Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass all exceptions, catch none #11

Open
chrisinmtown opened this issue Feb 10, 2016 · 0 comments
Open

Pass all exceptions, catch none #11

chrisinmtown opened this issue Feb 10, 2016 · 0 comments

Comments

@chrisinmtown
Copy link

Thank you for this code. Suggest revising the constructor and other methods to throw IOException; i.e., remove all try-catch blocks. A library should not catch any exceptions, just let them bubble up so I can deal with them most appropriately in my code. As currently written I can't detect whether the constructor succeeded!

@chrisinmtown chrisinmtown changed the title Need additional input stream in Expect() to monitor stderr from process Extend to monitor stderr from process Feb 10, 2016
@chrisinmtown chrisinmtown changed the title Extend to monitor stderr from process Pass all exceptions, catch none Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant