Implement cosmwasm_vm Move Bind #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
yubing744
force-pushed
the
owen/bitseed/use-cosm-wasm
branch
from
5e84801
to
e6ca471
Compare
yubing744
force-pushed
the
owen/bitseed/use-cosm-wasm
branch
from
a1f34f5
to
97511de
Compare
yubing744
force-pushed
the
owen/bitseed/use-cosm-wasm
branch
from
97511de
to
6079059
Compare
yubing744
force-pushed
the
owen/bitseed/use-cosm-wasm
branch
from
8d1205c
to
70539ea
Compare
yubing744
requested review from
wow-sven,
geometryolife,
pause125,
baichuan3,
steelgeek091,
yourmoonlight and
popcnt1
as code owners
|
@jolestar help review. |
jolestar
reviewed
Sep 25, 2024
| })?; | ||
|
|
||
| // Save WASM bytecode and get checksum | ||
| let checksum = WASM_CACHE.save_wasm(&bytecode).map_err(|e| { |
There was a problem hiding this comment.
The Cache module of cosmwasm-vm is implemented in three layers at the base level:
- Fixed Memory Cache: Modules that are pinned are stored in this cache layer.
- In-Memory Cache: Modules that are not pinned but remain in memory.
- File System Cache: Modules stored on disk.
There was a problem hiding this comment.
The third disk storage is the configured system temporary directory.
Comment on lines
+30
to
+45
| public fun from_code(code: vector<u8>): Result<Instance, Error> { | ||
| features::ensure_wasm_enabled(); | ||
|
|
||
| let store = table::new<String, vector<u8>>(); | ||
| let store_handle = table::handle(&store); | ||
|
|
||
| let (checksum, error_code) = native_create_instance(code, store_handle); | ||
| if (error_code == 0) { | ||
| ok(Instance { | ||
| code_checksum: checksum, | ||
| store: store, | ||
| }) | ||
| } else { | ||
| table::drop(store); | ||
| new_error_result(error_code, string::utf8(b"native_create_instance_error")) | ||
| } |
There was a problem hiding this comment.
感觉这里应该返回 Object, 这样就不需要那个 table 了，直接把 Object 动态字短作为 store。
There was a problem hiding this comment.
Using Object is also possible, but it seems that using Table here makes the logic clearer.
…en/bitseed/use-cosm-wasm
jolestar
approved these changes
Sep 26, 2024
OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summary about this PR
Implement cosmwasm_vm Move Bind #2690
TODO