[rpc] add limit to object_ids #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegetabledogdog
requested review from
wow-sven,
baichuan3 and
jolestar
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
baichuan3
reviewed
Sep 27, 2024
| @@ -122,6 +122,7 @@ impl RpcService { | |||
| access_path: AccessPath, | |||
| state_root: Option<H256>, | |||
| ) -> Result<Vec<Option<ObjectState>>> { | |||
| access_path.validate_max_object_ids()?; | |||
There was a problem hiding this comment.
可以考虑把 access_path 的校验放到 rpc_server中完成，rpc_server是 rpc 的入口层，参数校验都可以在这一层完成
baichuan3
reviewed
Sep 27, 2024
| @@ -291,6 +291,19 @@ impl AccessPath { | |||
| }) | |||
| } | |||
|
|
|||
| pub fn validate_max_object_ids(&self) -> Result<()> { | |||
| const MAX_OBJECT_IDS: usize = 100; | |||
There was a problem hiding this comment.
建议定义成全局的pub const，用于 object ids 的判断
vegetabledogdog
force-pushed
the
cli
branch
from
90ae4c5
to
e577d35
Compare
baichuan3
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid oom