Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Faucet Refactor and Command Enhancement #2706

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Conversation

jolestar
Copy link
Contributor

@jolestar jolestar commented Sep 28, 2024

Summary

This pull request introduces a comprehensive refactor of the Faucet functionality and enhances the CLI for better usability and maintenance.

  1. Renamed gas_airdrop to gas_faucet for clarity.
  2. Refactored the Faucet implementation to call gas_faucet contract to claim RGas.
  3. Integrated the Faucet as a sub-command within the rooch CLI, accessible via rooch faucet server.
  4. Set the default port for the Faucet to 6868 for consistency.

Copy link

vercel bot commented Sep 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rooch-portal-v2.1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2024 8:11pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
rooch ⬜️ Ignored (Inspect) Sep 28, 2024 8:11pm

@jolestar jolestar requested review from mx819812523 and wow-sven and removed request for baichuan3, wow-sven and pause125 September 28, 2024 20:11
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@jolestar jolestar changed the title [CLI] Faucet refactor [CLI] Faucet Refactor and Command Enhancement Sep 28, 2024
@wow-sven
Copy link
Collaborator

后面测试网也需要utxo 才能领取gas了吗

@jolestar
Copy link
Contributor Author

后面测试网也需要utxo 才能领取gas了吗

合约里有设置,默认不需要。

@jolestar jolestar merged commit def2bd4 into main Sep 29, 2024
10 checks passed
@jolestar jolestar deleted the faucet_refactor branch September 29, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants