Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail in node 12 #726

Closed
kethinov opened this issue Jun 1, 2019 · 1 comment · Fixed by #729
Closed

Tests fail in node 12 #726

kethinov opened this issue Jun 1, 2019 · 1 comment · Fixed by #729
Labels
bug help wanted mentor available A maintainer is available to help you work on this if you take it up

Comments

@kethinov
Copy link
Member

kethinov commented Jun 1, 2019

No description provided.

@kethinov kethinov added bug help wanted mentor available A maintainer is available to help you work on this if you take it up labels Jun 1, 2019
@reecer62
Copy link
Contributor

reecer62 commented Jun 3, 2019 •
edited
Loading

The first test that fails is in CSS Section Tests. In Node 12, this PR was merged nodejs/node#27109. What this did was turn the compact and breakLength values on by default. So this line:

(app) => { return { versionCode: (app) => { return 1 }, parse: (app, fileName) => { return 1 } } }

was broken up and was splitting up the code into multiple lines. This caused the code to have invalid syntax which gave an error during the test.

@reecer62 reecer62 mentioned this issue Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted mentor available A maintainer is available to help you work on this if you take it up
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed tests in Node 12 reecer62/roosevelt
2 participants
@kethinov @reecer62