Update WP theme paths task incorrectly checks wp_template_root var

[tmdk]

Submit a feature request or bug report

• I've read the guidelines for Contributing to Roots Projects
• This is a feature request
• This is a bug report
• This request isn't a duplicate of an existing issue
• I've read the docs and followed them (if applicable)
• This is not a personal support request that should be posted on the Roots Discourse forums

Bug report

The options template_root and theme_root are overridden on deploy even if template_root is empty or set to /themes . As a result, it can break the activated theme (see discourse discussion below)

It seems the fix for #718 contains a bug: i think it should compare wp_template_root.stdout instead of wp_template_root in the Update WP theme paths task.

Please describe your local environment:

Ansible version: 2.2.0.0

OS: Windows 10

Vagrant version: 1.9.1

Where did the bug happen? Development or remote servers?

Remote

Is there a related Discourse thread or were any utilized (please link them)?

Seems to be discussing the same bug: https://discourse.roots.io/t/the-theme-directory-theme1-does-not-exist/8485/12

[akovalyov]

I can confirm that I experience this bug. I have a custom theme in site/web/app/themes folder. Right now after each deployment I need to activate one of default themes and reactivate a custom one.

[retlehs]

you can try reverting #720 in the meantime

[akovalyov]

@retlehs awesome, it worked! Thanks a lot! Probably the solution which was proposed via wp option is not complete.

[emanuelet]

Deploying with the latest code from master I encountered a similar problem where apparently the option was pointing to web/wp-content/themes while I have my theme in web/app/themes and so I had to manually change the configuration in Update WP theme paths