Use append_privs for WP DB privileges #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would say you should have separate DB users :) But regardless, this seems like a good default to have anyway. Thanks! |
| @@ -11,6 +11,7 @@ | |||
| - name: Create/assign database user to db and grant permissions | |||
| mysql_user: name="{{ item.value.env.db_user }}" | |||
| password="{{ item.value.env.db_password }}" | |||
| append_privs=true | |||
There was a problem hiding this comment.
Can you use yes instead of true? Matches up with Ansible docs.
There was a problem hiding this comment.
New commit coming within minutes. I was not sure, as if you see the same page I pasted above, the example has true. 😕
There was a problem hiding this comment.
Yeah that's inconsistent on their part :( But they always use yes/no in the options section of their docs.
|
@primozcigler would you be able to squash these commits? |
primozcigler
force-pushed
the
append-privs
branch
from
e9b3084
to
66a67da
Compare
This change allows that multiple WP installations share the same db user.
|
@swalkinshaw indeed, my bad 👍 |
swalkinshaw
added a commit
that referenced
this pull request
Nov 26, 2015
Added append_privs to WP setup - databases.
swalkinshaw
changed the title
swalkinshaw
changed the title
QWp6t
pushed a commit
that referenced
this pull request
Dec 24, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows that multiple WP installations share the same db
user.
Check the docs here: http://docs.ansible.com/ansible/mysql_user_module.html
For example I might have multiple WP installations, but a common scenario is to have a 1 DB user which will have access to multiple WP databases.