Require explicit redirects and drop www_redirect

[fullyint]

Discontinues the reverse_www filter, overcoming its challenges in determining when to add/remove www in presence of subdomains.

Some history in #570 and #619.

Example of problem to solve: https://discourse.roots.io/t/https-www-unsecure-and-not-redirecting/7071/

[swalkinshaw]

possible

[swalkinshaw]

  site_hosts = wordpress_sites.flat_map { |(_name, site)| site['site_hosts'] }

  site_hosts.each do |host|
    if !host.is_a?(Hash) or !host.has_key?('canonical')
      fail_with_message File.read(File.join(ANSIBLE_PATH, 'roles/common/templates/site_hosts.j2')).sub!('{{ env }}', 'development').gsub!(/com$/, 'dev')
    end
  end

  main_hostname, *hostnames = site_hosts.map { |host| host['canonical'] }
  config.vm.hostname = main_hostname

  redirects = site_hosts.flat_map { |host| host['redirects'] }.compact

  if Vagrant.has_plugin? 'vagrant-hostmanager'
    config.hostmanager.enabled = true
    config.hostmanager.manage_host = true
    config.hostmanager.aliases = hostnames + redirects
  else
    fail_with_message "vagrant-hostmanager missing, please install the plugin with this command:\nvagrant plugin install vagrant-hostmanager"
  end

[fullyint]

Your refactor of site_hosts mapping is sooo much better. Thanks!

[swalkinshaw]

Can this be site_hosts | join(' ')?

[fullyint]

The disappointment here is that it uses item.item.value.site_hosts.
We would need just item.value.site_hosts in order to use site_hosts from helpers.yml.

I tried opening the template with {% set item = item.item %} but it doesn't work.
If it feels cleaner or more consistent, we could open the template with
{% set canonical = ... [something] %}
{% set redirects = ... [something] %}
{% set site_hosts = ... [something with union] %}
and then do the site_hosts | join(' ')

[swalkinshaw]

Not worth it, good as is 👌

[swalkinshaw]

💯 so much better