Refactor --subdomains flag in the Install WP task #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the [documentation](https://developer.wordpress.org/cli/commands/core/multisite-install/) the existance of the --subdomains is boolean value. If the item.value.multisite.subdomains was set to false (or not set) this task was treating it as it's set to true. This commit is fixing this.
|
😱 good find. Did this actually cause a bug or break something? I actually wonder if Either way, it's more accurate 👍 |
|
@swalkinshaw it does not work. That's how I found the bug 😉 And I've also tested it and with my fix, it works as it's supposed to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation the existance of the --subdomains is boolean value. If the
item.value.multisite.subdomainswas set to false (or not set) this task was treating it as it's set to true.This commit is fixing this.