the "limit" argument doesn't get overridden by the "limit" or "count" argument passed in a list options to the ft_search function

[vipulg13]

Dear Team,

first of all, thanks for this incredible one shot interface.

As I stated in the title field, it would be great if you could make a necessary changes in your plugins functions, such that if the limit or count argument is passed in the list options specific to the data source, then it gets precedence over the function level "limit" argument. This will provide great flexibility to the user, as the user can set the values for different data sources in a preferential manner and get the desirable results through a single function call.

Let me know if you need further details from my side.

Regards,
Vipul

[sckott]

Thanks for the issue. I'll have a look

[sckott]

@vipulg13 should work now, reinstall pak::pkg_install("ropensci/fulltext")

[vipulg13]

thanks @sckott, it is now working as expected.
Just a small note: you could also consider making a slight change in the plugin_search_crossref(...) module to get rid of below warning-

Warnmeldung:
tbl_df() is deprecated as of dplyr 1.0.0.
Please use tibble::as_tibble() instead.

[sckott]

great, glad it works. thanks for the note

[sckott]

the warning comes from a dependency - not sure which one, possibly from rcrossref, but if that pkg then its an older version of it as the current version doesn't use tbl_df anywhere