Skip to content
This repository has been archived by the owner on May 10, 2022. It is now read-only.

Update to v3.4.1 #49

Closed
sckott opened this issue May 17, 2016 · 8 comments
Closed

Update to v3.4.1 #49

sckott opened this issue May 17, 2016 · 8 comments
Milestone

Comments

@sckott
Copy link
Contributor

sckott commented May 17, 2016

https://github.com/Turfjs/turf/blob/master/CHANGELOG.md#301

@sckott
Copy link
Contributor Author

sckott commented Jun 18, 2016

@sckott sckott changed the title Update to v3.0.1 Update to v3.4.1 Jul 21, 2016
@sckott
Copy link
Contributor Author

sckott commented Jul 21, 2016

methods that are no longer in new version of lawn:

  • lawn_average
  • lawn_deviation
  • lawn_count
  • lawn_filter
  • lawn_max
  • lawn_median
  • lawn_min
  • lawn_sum
  • lawn_variance
  • turf-erase has been renamed turf-difference to make its name more similar to the equivalents in other libraries.

lawn_jenks needs extra work to get to work again, see note within https://github.com/Turfjs/turf/blob/master/CHANGELOG.md#301

lawn_quantile needs extra work to get to work again, see note within https://github.com/Turfjs/turf/blob/master/CHANGELOG.md#301

remove lawn_reclass - its depredated in turf Turfjs/turf#306

remove lawn_size - its depredated in turf Turfjs/turf#306

sckott added a commit that referenced this issue Jul 21, 2016
for those that still need changes, made examples dontrun for now
#49
@sckott sckott added this to the v0.2 milestone Oct 12, 2016
@sckott
Copy link
Contributor Author

sckott commented Oct 13, 2016

hey @jhollist - sorry about the delay, got most things working, some things left to think about

note the work is on branch turf-v3, not on master

  • lawn_jenks - should we keep this? we'd have to write the js from scratch, test commented out for now
  • lawn_quantile - should we keep this? we'd have to write the js from scratch, test commented out for now
  • lawn_aggregate - a new method collect http://turfjs.org/docs/#collect was introduced, i think to replace aggregate in part at least, now aggregate is gone from turf. should we just make this method defunct?
  • should we add a function for the new method http://turfjs.org/docs/#collect ?

I added these new methods under the helper section of the turf docs

  • feature
  • multiLineString
  • multiPoint
  • multiPolygon
  • geometryCollection

SOME METHODS NOT FOUND IN CURRENT TURF, MOVING THOSE METHODS TO NEXT MILESTONE

@jhollist
Copy link
Collaborator

My gut reaction is to have lawn mirror the current version of turf as closely as possible. Thus we could drop lawn_jenks and lawn_quantile, and replace lawn aggregate with a lawn version of collect.

Haven't looked at the other methods yet. Won't have much time next couple of weeks. Sorry.

@sckott
Copy link
Contributor Author

sckott commented Oct 14, 2016

Okay, and easier to just drop those too. those meta and assertions methods may push off until some later point if I can't sort out where they are

@jhollist
Copy link
Collaborator

Sounds good.

As far as submission to JOSS, I hope to work on that soon. Some potential confusion around licensing that EPA hasn't thought about it. If I don't get clarification in a timely fashion, I'll just ignore the issue and work up the submission.

@sckott
Copy link
Contributor Author

sckott commented Oct 14, 2016

Okay

@sckott
Copy link
Contributor Author

sckott commented Oct 17, 2016

moved methods not found in current turf release to new issue for next milestone #51

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants