Skip to content
This repository has been archived by the owner on May 10, 2022. It is now read-only.

Disable overly eager unit tests #45

Merged
merged 1 commit into from
Mar 3, 2016
Merged

Disable overly eager unit tests #45

merged 1 commit into from
Mar 3, 2016

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented Mar 3, 2016

Latest version of V8 fixes a small bug which caused a cryptic error message when evaluating nothing:

ctx <- V8::v8()
ctx$eval(character(0))
## error: "ReferenceError: NA is not defined"

The new version coerces input to a string so it becomes ctx$eval("") which evaluates to null. However lawn has a unit test that specifically tests for the old error message. This PR disables that test.

sckott added a commit that referenced this pull request Mar 3, 2016
@sckott
Merge pull request #45 from jeroenooms/master
1eca80c 
Disable overly eager unit tests
@sckott sckott merged commit 1eca80c into ropensci-archive:master Mar 3, 2016
@sckott sckott added this to the v0.1.6 milestone Mar 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.6
Development

Successfully merging this pull request may close these issues.
2 participants
@jeroen @sckott