-
Notifications
You must be signed in to change notification settings - Fork 200
Reduce tweet fields returned by default #558
Comments
IOTW I'm suggesting that the data frame unpacking that currently occurs in |
Is it intentional/temporary that since #572 |
It is an error I didn't detect when I merged the PR. Thanks @simonheb for asking!! It is incorrectly processed and later on lost (but should be on |
Sorry @simonheb I checked more about the issue and it turned out I used incorrect code, The correct function data to retrieve the screen name is |
Ok thanks. But this is just a quick fix, no? In the long run |
They already return this data but it is on an attribute. It is not a quick fix, I had not to do anything here for this to work between the comments. I agree with Hadley that having 70 columns was not not practical. At the moment I don't plan to change the columns or how the information is returned anytime soon. |
Hi @mkearney many thanks for your encouraging words. Sorry for the surprise when you installed the development version of the package and it broke your scripts. It was not my intention when I offered to help maintaining the package. I am aware that changing the column names will break scripts and other packages, that's one of the reasons why it will take some more time until I think about sending the package to CRAN. Perhaps there will be one other breaking change before sending it to CRAN as we were considering renaming the functions. Additionally, there are still some bugs we have introduced I would like to fix and I want to make it easier to transition from 0.7.0 version to this one. Perhaps one of the ways might be adding some helpers to extract columns and rename them. All feedback is welcome, specially if we made something harder or you have other comments to improve the package. While we've tried to mirror more the actual API data structure one of the main reasons of its success is due to the flattening of the data it does. There is still some work to do on that front as some of the columns have now a nested structure (and save_as_csv and write_as_csv, have not been adapted yet) but it is something important for the analysis we'll keep. |
You don't need to apologize, @llrs! You've been doing all of the [great] work here, so the last thing you should worry about is my old scripts working. It seems you've been very thoughtful about everything, so in the meantime, I'll try to give this (how to ease the transition for users) some thought and see if I can't help make this happen! |
@mkearney I've sent you an email to the address listed on the description, not sure if you receive them... I suggested having the hackathon the 27th November or 4th of December. See this thread on the slack channel package-maintenance of rOpenSci. What do you think? Would you like to join the conversation there? |
Current
search_tweets()
and friends returns a data frame with 73 columns:I'd suggest that we return fewer more complicated columns by default, instead providing some helpers to access them when needed. For example, we could keep
media_*
,quoted_*
andretweet_*
inmedia
,quoted
andrtweet
columns and provide helpers to expand them out when needed.The text was updated successfully, but these errors were encountered: